Skip to content
This repository has been archived by the owner on Nov 16, 2019. It is now read-only.

Commit

Permalink
Fixbug for running in Node express
Browse files Browse the repository at this point in the history
Update readme

Update package.json
  • Loading branch information
gallenhu committed Jul 5, 2016
1 parent 5086d72 commit 96ab2aa
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 72 deletions.
69 changes: 3 additions & 66 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,67 +1,4 @@
# Open Browser Webpack Plugin
Opens a new browser tab when Webpack loads. Very useful if you're lazy and don't want to force yourself to open a new tab when Webpack is ready to play!
# Open Browser Webpack Express Plugin
Base on [Open Browser Webpack Plugin](https://github.com/baldore/open-browser-webpack-plugin).

## Usage

Simply require the plugin and add it in the **plugins** section:

```javascript
var OpenBrowserPlugin = require('open-browser-webpack-plugin');

module.exports = {
entry: path.resolve(__dirname, 'lib/entry.js'),
output: {
path: __dirname + "/bundle/",
filename: "bundle.js"
},
plugins: [
new OpenBrowserPlugin({ url: 'http://localhost:3000' })
]
};
```

## Options

#### url

Type: `String`<br>
Default: `http://localhost:8080`

Url to open when Webpack is ready. Needs to have the prefix `http://` or `https://` in order to open the browser.

#### browser

Type: `String`<br>
Optional

Browser to open. By default, it will try to open the browser set by default in your system.

#### ignoreErrors

Type: `String`<br>
Default: `False`<br>
Optional

By default this plugin only opens the browser if there's no Webpack errors. Setting ignoreErrors to true will open a new tab no matter the compilation errors.

## Change Log

### 0.0.2 - 2015-12-26
#### Added
- ignoreErrors option (Thanks to @zhura).
- Changelog.
- Documentation for options.

#### Removed
- DEFAULT_BROWSER constant.

### 0.0.1 - 2015-09-12
- First release.

## TODO

- [ ] Add tests.

## License

MIT License.
Adapt Node Express Proxy by Opening Browser Async.
4 changes: 3 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ OpenBrowserPlugin.prototype.apply = function(compiler) {

compiler.plugin('done', function doneCallback(stats) {
if (isWatching && (!stats.hasErrors() || ignoreErrors)) {
removeFromArray(stats.compilation.compiler._plugins['done'], doneCallback);
setTimeout(function () {
removeFromArray(stats.compilation.compiler._plugins['done'], doneCallback);
}, 0);
open(url, browser, function(err) {
if (err) throw err;
});
Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "open-browser-webpack-plugin",
"version": "0.0.2",
"name": "open-browser-webpack-express-plugin",
"version": "0.0.3",
"description": "Opens the browser when Webpack is ready serving your files.",
"main": "index.js",
"scripts": {
Expand All @@ -9,7 +9,7 @@
},
"repository": {
"type": "git",
"url": "git+https://github.com/baldore/webpack-open-plugin.git"
"url": "git+https://github.com/GallenHu/open-browser-webpack-plugin.git"
},
"keywords": [
"webpack",
Expand All @@ -23,9 +23,9 @@
"author": "Camilo Orrego",
"license": "MIT",
"bugs": {
"url": "https://github.com/baldore/webpack-open-plugin/issues"
"url": "https://github.com/GallenHu/open-browser-webpack-plugin/issues"
},
"homepage": "https://github.com/baldore/webpack-open-plugin#readme",
"homepage": "https://github.com/GallenHu/open-browser-webpack-plugin#readme",
"dependencies": {
"open": "0.0.5"
},
Expand Down

0 comments on commit 96ab2aa

Please sign in to comment.