Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Remove fragments from the pool query, issue with generated types #122

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

danielmkm
Copy link
Collaborator

Description

The generated pool type has the issue described here because of the nested fragments:
dotansimha/graphql-code-generator-community#140 (comment)

For the sake of simplicity, I just removed all of the nested fragments from the query, and the types are then generated as you'd expect.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test
configuration.

  • Test A
  • Test B

Visual context

Please provide any relevant visual context for UI changes or additions. This could be static
screenshots or a loom screencast.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 10:23am

@garethfuller garethfuller merged commit feb58b9 into main Dec 6, 2023
6 checks passed
@garethfuller garethfuller deleted the chore/remove-pool-query-fragments branch December 6, 2023 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants