Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Reload page on dynamic module load error #2777

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

agualis
Copy link
Collaborator

@agualis agualis commented Feb 8, 2023

Description

Workaround for Failed to fetch dynamically imported module error..

Closes #2778

Sentry link: https://balancer-labs.sentry.io/issues/3922269920/?project=5725878

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

  1. Open https://beta.balancer.fi/#/
  2. Wait for merge and deploy and check if the error is gone.

Visual context

Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@agualis agualis self-assigned this Feb 8, 2023
@agualis agualis changed the title Reload page on dynamic module load error Bugfix: Reload page on dynamic module load error Feb 8, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 73457e0
Status: ✅  Deploy successful!
Preview URL: https://12b45fd2.balancer-d6h.pages.dev
Branch Preview URL: https://fix-failed-module-load.balancer-d6h.pages.dev

View logs

@garethfuller garethfuller merged commit 3750948 into develop Feb 8, 2023
@garethfuller garethfuller deleted the fix/failed-module-load branch February 8, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to fetch dynamically imported module
3 participants