docs: update errors #262
Draft
docs: update errors #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EndymionJkb
reviewed
May 2, 2025
| | `MulOverflow()` | `0x0cde6c26` | | MockGyroECLPPool | | ||
| | `DivInterval()` | `0xe03f5d57` | | MockGyroECLPPool | | ||
| | `OwnableUnauthorizedAccount(address)` | `0x118cdaa7` | address account | MockLBPool | | ||
| | `OwnableInvalidOwner(address)` | `0x1e4fbdf7` | address owner | MockLBPool | |
There was a problem hiding this comment.
InvalidOwner is in the LBPPoolFactory; not sure where it's getting the "Ownable" from. We don't use that OZ contract directly (with LBPs, anyway; some of the hooks do).
EndymionJkb
reviewed
May 2, 2025
| | `ContractNameAlreadyRegistered(ContractType,)` | `0xdecd1563` | ContractType contractType, string contractName | MevCaptureHook | | ||
| | `ContractNameInUseAsAlias(string,)` | `0xedcd5939` | string contractName, address contractAddress | MevCaptureHook | | ||
| | `ContractAliasInUseAsName(ContractType,)` | `0xc5949bff` | ContractType contractType, string contractName | MevCaptureHook | | ||
| | `ContractNameNotRegistered(string)` | `0xcd3599f9` | string contractName | MevCaptureHook | |
There was a problem hiding this comment.
ContractNameNotRegistered is in the BalancerContractRegistry
EndymionJkb
reviewed
May 2, 2025
| | `AmplificationFactorTooLow()` | `0xab923323` | | MockStablePool | | ||
| | `AmplificationFactorTooHigh()` | `0x9b80d390` | | MockStablePool | | ||
| | `AmpUpdateDurationTooShort()` | `0xcd6b022a` | | MockStablePool | | ||
| | `AmpUpdateRateTooFast()` | `0x1c708b92` | | MockStablePool | |
There was a problem hiding this comment.
The AmpUpdate errors are in regular StablePool - are you doing this by reading the ABI, vs. reading the contracts? There really shouldn't be any "Mock" contracts. (They sometimes do declare their own errors, but just for tests, so I don't think they need to be documented.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on automating the error code updates.