[request] Add patch column patch

[siduck]

Hi @bakkeby , st cuts text inside it when st's window is resized :/ . Most terminals dont do this. I didnt find any patches for it either.

I found a build which has this issue fixed , seems like it extends the patch column from here.

@BeyondMagic 's build didnt provide any patch for it tho , I found some useful commits BeyondMagic/flarity@4339de9.

( st without patch column and with it (beyondmagic's build) )

simplescreenrecorder-2021-07-22_07.54.21.mp4

It would be very nice if there was a patch for this :]

[siduck]

My friend made a patch for it https://github.com/coolabhays/st_custom/blob/master/patches/st-columnredraw-20210722-e40efda.diff , it works but sometimes forward scrolling crashes st

simplescreenrecorder-2021-07-22_23.24.39.mp4

[siduck]

FINALLY GOT A PATCH THAT WORKS!

https://github.com/nimaipatel/st/blob/master/patches/7672445bab01cb4e861651dc540566ac22e25812.diff

[bakkeby]

This certainly feels much more convenient, makes you wonder why it's not in st by default, it doesn't add many lines of code.

In practice this is the same feature as provided by the vim browse patch, but without all of the other features that the vim browse patch adds.

[siduck]

This certainly feels much more convenient, makes you wonder why it's not in st by default, it doesn't add many lines of code.

In practice this is the same feature as provided by the vim browse patch, but without all of the other features that the vim browse patch adds.

Vim browse removes the functionality of a rollback iirc , also this patch works unless you resize the window vertically which duplicates the prompt , check the issue in its repo.

[bakkeby]

Maybe there is something special going on with the last lines printed (or the prompt). This is also the case if you don't have this patch though.

[siduck]

@bakkeby if you dont mind , could you update the patch column patch in your free time? Ive seen a build which has this patch and scrolling vertically doesnt cut the text too.

Example : My build ( with patch column patch) and this build(with modified patch column so vertically resizing doesnt cut the text)

simplescreenrecorder-2021-08-08_12.07.21.mp4

ashish-yadav11/st#1

[bakkeby]

I saw that build, it is pretty slick. He has done a lot of changes in his build. I'm hoping he'll release a standalone patch at some point, otherwise I'll have to go through all his changes.

I'll get around to this eventually, I have quite a few things in my backlog.

[BeyondMagic]

Did you all get far with vertical resizing?

I can finally give a look at it, after all those months.

[siduck]

Did you all get far with vertical resizing?

I can finally give a look at it, after all those months.

not yet ;(

[BeyondMagic]

I'm trying to make it work basing on the ashish-yadav11 build, though I don't premise anything.

[BeyondMagic]

Yeah, I'm giving up. His build is coded in a way that is beyond my skills in C.

[bakkeby]

Well, the good news is that he hasn't updated his build in the last three months which I take to mean that his work is pretty stable :)

So the build is here:

• https://github.com/ashish-yadav11/st

Trying it out I see that he added reflow to the main terminal as well.

Looking at the files changed tab here we can see all the custom changes that were made to this repository:
ashish-yadav11/st@4536f46...d84cd16

To be honest it is less changes than I expected, but the tricky part is figuring out which changes are relevant and what not.