fix: fix issues discovered by sonarcloud (argoproj#5416)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
bainss · Feb 5, 2021 · f0d8129 · f0d8129
1 parent d9e9a99
commit f0d8129
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/ui/src/app/applications/components/utils.tsx b/ui/src/app/applications/components/utils.tsx
@@ -544,7 +544,7 @@ export function getPodStateReason(pod: appModels.State): {message: string; reaso
             } else if (container.state.terminated && container.state.terminated.reason) {
                 reason = container.state.terminated.reason;
                 message = container.state.terminated.message;
-            } else if (container.state.terminated && container.state.terminated.reason) {
+            } else if (container.state.terminated && !container.state.terminated.reason) {
                 if (container.state.terminated.signal !== 0) {
                     reason = `Signal:${container.state.terminated.signal}`;
                     message = '';

diff --git a/ui/src/app/login/components/login.scss b/ui/src/app/login/components/login.scss
@@ -5,8 +5,6 @@ $logoNegativePath: 'assets/images/argo.png';
 
 .login {
     min-height:100vh;
-    background-position: 15rem;
-    background-size: cover;
     background: linear-gradient(to top left, 
         rgba(122, 139, 207, 0.8) 0%, 
         rgba(46, 50, 90, 0.8) 100%), 

diff --git a/ui/src/app/ui-banner/ui-banner.scss b/ui/src/app/ui-banner/ui-banner.scss
@@ -7,7 +7,6 @@
     position: fixed;
     width: 100%;
     z-index: 10;
-    align-items: center;
     text-align: center;
     color: $argo-color-teal-8;
     font-weight: 500;