lazy init of authenticator

baifalove · Nov 29, 2017 · 3aa5102 · 3aa5102
1 parent f6bb214
commit 3aa5102
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/proxy/shadowsocks/protocol.go b/proxy/shadowsocks/protocol.go
@@ -299,7 +299,6 @@ func DecodeUDPPacket(user *protocol.User, payload *buf.Buffer) (*protocol.Reques
 	account := rawAccount.(*MemoryAccount)
 
 	var iv []byte
-	var authenticator *Authenticator
 	if !account.Cipher.IsAEAD() && account.Cipher.IVSize() > 0 {
 		// Keep track of IV as it gets removed from payload in DecodePacket.
 		iv = make([]byte, account.Cipher.IVSize())
@@ -333,7 +332,7 @@ func DecodeUDPPacket(user *protocol.User, payload *buf.Buffer) (*protocol.Reques
 			payloadLen := payload.Len() - AuthSize
 			authBytes := payload.BytesFrom(payloadLen)
 
-			authenticator = NewAuthenticator(HeaderKeyGenerator(account.Key, iv))
+			authenticator := NewAuthenticator(HeaderKeyGenerator(account.Key, iv))
 			actualAuth := make([]byte, AuthSize)
 			authenticator.Authenticate(payload.BytesTo(payloadLen))(actualAuth)
 			if !bytes.Equal(actualAuth, authBytes) {