feat(without): skip testing some modules using --without option, close …

…#57

bin/next-update.js

@@ -51,7 +51,8 @@ if (program.available) {
     keep: program.keep,
     allow: allow,
     type: program.type,
-    tldr: program.tldr
+    tldr: program.tldr,
+    without: program.without
   }
 
   var checkCurrent = nextUpdate.checkCurrentInstall.bind(null, opts)

package.json

@@ -41,6 +41,7 @@
     "lodash": "3.10.1",
     "npm-utils": "1.7.1",
     "optimist": "0.6.1",
+    "pluralize": "5.0.0",
     "q": "2.0.3",
     "quote": "0.4.0",
     "ramda": "0.24.1",

src/dependencies.js

@@ -8,6 +8,7 @@ var print = require('./print-modules-table')
 var nameVersionParser = require('./moduleName')
 var getKnownDependencies = require('./get-known-dependencies')
 const {getSkippedModules} = require('./utils')
+const pluralize = require('pluralize')
 
 require('console.table')
 var _ = require('lodash')
@@ -41,6 +42,7 @@ function printTable (options, nameVersionPairs) {
         ? nameVersionPairs
         : _.filter(nameVersionPairs, { type: allowedType })
 
+  // TODO just use Ramda project
   console.table(title, _.map(filtered, function (nameVersion) {
     return {
       module: nameVersion.name,
@@ -80,9 +82,14 @@ function normalizeModuleNames (moduleNames) {
 
 function getDependenciesToCheck (options, moduleNames) {
   check.verify.object(options, 'missing options')
-  debug('initial module names', moduleNames)
+  debug('get dependencies for options')
+  debug(options)
   moduleNames = normalizeModuleNames(moduleNames)
-  debug('normalized module names', moduleNames)
+  if (moduleNames) {
+    debug('normalized module names', moduleNames)
+  } else {
+    debug('no --module filter')
+  }
 
   var workingDirectory = process.cwd()
 
@@ -97,6 +104,16 @@ function getDependenciesToCheck (options, moduleNames) {
     }
     nameVersionPairs = remove(nameVersionPairs, skipModules)
   }
+  if (options.without) {
+    la(check.array(options.without),
+      'without should be an array', options.without)
+    if (check.unempty(options.without)) {
+      debug('checking without %s %s',
+        pluralize('module', options.without.length),
+        options.without.join(', '))
+      nameVersionPairs = remove(nameVersionPairs, options.without)
+    }
+  }
   printTable(options, nameVersionPairs)
 
   var toCheck = nameVersionPairs

src/next-update-as-module.js

@@ -13,7 +13,8 @@ module.exports = function nextUpdateTopLevel (options) {
     allow: options.allow || options.allowed,
     type: options.type,
     changedLog: options['changed-log'],
-    limit: is.maybe.fn(options.limit) ? options.limit : T
+    limit: is.maybe.fn(options.limit) ? options.limit : T,
+    without: options.without
   }
 
   const checkUpdates = nextUpdate.checkAllUpdates.bind(null, opts)

src/next-update.js

@@ -109,6 +109,10 @@ function checkAllUpdates (options) {
     console.log('will check only latest versions because testing all')
   }
 
+  if (check.string(options.without)) {
+    options.without = [options.without]
+  }
+
   if (check.string(moduleName)) {
     moduleName = [moduleName]
   }

src/registry.js

@@ -3,6 +3,7 @@
 var la = require('lazy-ass')
 var check = require('check-more-types')
 var log = require('debug')('next-update')
+const R = require('ramda')
 
 var request = require('request')
 var verify = check.verify
@@ -225,7 +226,7 @@ function fetchVersions (nameVersion) {
         }
         log('extracting versions')
         var versions = extractVersions(info)
-        log('versions', versions)
+        log('%d versions', versions.length)
 
         if (!Array.isArray(versions)) {
           throw new Error('Could not get versions for ' + name +
@@ -235,8 +236,14 @@ function fetchVersions (nameVersion) {
 
         var validVersions = versions.filter(cleanVersionForName)
         var newerVersions = validVersions.filter(isLaterVersion)
-        log('valid versions', validVersions)
-        log('newer versions', newerVersions)
+        log('%d valid versions', validVersions.length)
+        if (validVersions.length) {
+          log('last version %s', R.last(validVersions))
+        }
+        if (newerVersions.length) {
+          log('%d newer versions', newerVersions.length)
+          log('from %s to %s', R.head(newerVersions), R.last(newerVersions))
+        }
 
         deferred.resolve({
           name: name,
@@ -269,10 +276,16 @@ function nextVersions (options, nameVersionPairs, checkLatestOnly) {
   var fetchAllPromise = q.all(fetchPromises)
         .timeout(MAX_CHECK_TIMEOUT, 'timed out waiting for NPM')
 
+  function logFetched (fetched) {
+    fetched.forEach(individual => {
+      log('%s - %d versions', individual.name, individual.versions.length)
+    })
+  }
+
   return fetchAllPromise.then(function (results) {
     check.verify.array(results, 'expected list of results')
     log('fetch all new version results')
-    log(results)
+    logFetched(results)
 
     var available = results.filter(function (nameNewVersions) {
       return nameNewVersions &&

test/as-parent-spec.js

@@ -30,6 +30,17 @@ describe('testing check-types', () => {
     return chdir.to(testFolder).then(prune).then(install).then(chdir.back)
   })
 
+  it('skips without module', function () {
+    this.timeout(TWO_MINUTES)
+    const opts = {
+      without: 'check-types',
+      keep: false
+    }
+    return nextUpdate(opts).then(results => {
+      la(results === undefined, 'no results without a module to check', results)
+    })
+  })
+
   it('checks latest check-types', function () {
     this.timeout(TWO_MINUTES)
     const opts = {