make work for cypress@7.x #269
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
confirmed this change makes our 34 svelte component tests work
Comment on lines
+6
to
+7
| const specType = Cypress?.spec?.specType // this will be present for cypress@6.x, but not for cypress@7.x | ||
| if (specType != null && specType !== 'component') { |
There was a problem hiding this comment.
@bahmutov, Cypress.spec.specType is undefined here and it may suffice to use Cypress.testingType
cc @JohnnyFun
There was a problem hiding this comment.
Another angle is that Cypress may no longer provide the specType attribute since it now has dedicated commands for component testing, open-ct and run-ct. And looking at the output from here, also shown below, it is safe to use Cypress.testingType
it('log spec info', () => {
console.log(Cypress.spec)
// {
// name: 'filter.spec.js',
// relative: 'cypress/integration/filter.spec.js',
// absolute: '/Users/janelane/Dev/web-app/cypress/integration/filter.spec.js',
// }
})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
confirmed this change makes our 34 svelte component tests work