Update angular-csv-import.js #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraped strictly executed code into a imidiately executed closure as it is commonly done in todays javascript libraries. This prefents issues from happening if the framework will be used in a probjekt in combinations with a bundleing framework and other javascript libararies that aren't marked as strict. Had an issue with that resulting in 'use strict' affecting the entire bundled script file which leaded to trouble when using firefox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraped strictly executed code into a imidiately executed closure as it is commonly done in todays javascript libraries. This prefents issues from happening if the framework will be used in a probjekt in combinations with a bundleing framework and other javascript libararies that aren't marked as strict. Had an issue with that resulting in 'use strict' affecting the entire bundled script file which leaded to trouble when using firefox.