Crop in pixel amounts instead of ratio #37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows exact pixel accurate cropping which is what users more
commonly want instead of using ratios.
The sliders for the crop amounts are hidden until open vr has been
initialized as we wouldn't know the maximum width and heigth values and
users wouldn't be able to see how their crop looks anyway.
Fixes #34
In my basic testing these changes work. Obs correctly remembers the previous crop values even when openvr is not yet running when obs starts up.
Feel free to make changes to the code yourself if you want to. Developing c++ with visual studio on windows is tedious for me so I'd rather be done with it and it is not important to me whether github credits me with the changes.
TODO:
Potential improvements:
Edit: I am debugging the latter issue with a small dummy plugin directly atm.