Release: version 5.4.0

CHANGELOG.md

@@ -1,3 +1,10 @@
+## Version 5.4.0 (October 3, 2018)
+- Upgraded target SDK version to 28 and support libraries to 28.0.0.
+- Upgraded ExoPlayer dependency to 2.8.3.
+- Moved `AdvancedBiddingInitializationAsyncTask` and `RefreshAdvertisingInfoAsyncTask` to the parallel executor.
+- MRAID `isViewable` now more closely follows our impression tracking instead of the ad being marked viewable as soon as it loads.
+- Bug fixes.
+
 ## Version 5.3.0 (August 15, 2018)
 - This release includes the foundation work for SDK to receive optimized responses for multiple placements from the waterfall. This effort will reduce the number of server roundtrips and minimize the ad response latency.
 - Upgraded ExoPlayer dependency to 2.8.2.

README.md

@@ -39,7 +39,7 @@ The MoPub SDK is available via:
     }
 
     dependencies {
-        implementation('com.mopub:mopub-sdk:5.3.0@aar') {
+        implementation('com.mopub:mopub-sdk:5.4.0@aar') {
             transitive = true
         }
     }
@@ -61,27 +61,27 @@ The MoPub SDK is available via:
         // ... other project dependencies
 
         // For banners
-        implementation('com.mopub:mopub-sdk-banner:5.3.0@aar') {
+        implementation('com.mopub:mopub-sdk-banner:5.4.0@aar') {
             transitive = true
         }
         
         // For interstitials
-        implementation('com.mopub:mopub-sdk-interstitial:5.3.0@aar') {
+        implementation('com.mopub:mopub-sdk-interstitial:5.4.0@aar') {
             transitive = true
         }
 
         // For rewarded videos. This will automatically also include interstitials
-        implementation('com.mopub:mopub-sdk-rewardedvideo:5.3.0@aar') {
+        implementation('com.mopub:mopub-sdk-rewardedvideo:5.4.0@aar') {
             transitive = true
         }
 
         // For native static (images).
-        implementation('com.mopub:mopub-sdk-native-static:5.3.0@aar') {
+        implementation('com.mopub:mopub-sdk-native-static:5.4.0@aar') {
             transitive = true
         }
 
         // For native video. This will automatically also include native static
-        implementation('com.mopub:mopub-sdk-native-video:5.3.0@aar') {
+        implementation('com.mopub:mopub-sdk-native-video:5.4.0@aar') {
             transitive = true
         }
     }
@@ -109,20 +109,17 @@ The MoPub SDK is available via:
 ## New in this Version
 Please view the [changelog](https://github.com/mopub/mopub-android-sdk/blob/master/CHANGELOG.md) for a complete list of additions, fixes, and enhancements in the latest release.
 
-- This release includes the foundation work for SDK to receive optimized responses for multiple placements from the waterfall. This effort will reduce the number of server roundtrips and minimize the ad response latency.
-- Upgraded ExoPlayer dependency to 2.8.2.
-- Upgraded recommended Google Play Services dependency to 15.0.1.
-- Upgraded target sdk version to 27 and support libraries to 27.1.1.
-- Upgraded Gradle dependency to 4.4.
-- Upgraded Android Plugin dependency to 3.1.3.
-- Upgraded test dependencies Powermock to 1.6.6 and Robolectric to 3.8.
+- Upgraded target SDK version to 28 and support libraries to 28.0.0.
+- Upgraded ExoPlayer dependency to 2.8.3.
+- Moved `AdvancedBiddingInitializationAsyncTask` and `RefreshAdvertisingInfoAsyncTask` to the parallel executor.
+- MRAID `isViewable` now more closely follows our impression tracking instead of the ad being marked viewable as soon as it loads.
 
 ## Requirements
 
 - Android 4.1 (API Version 16) and up (**Updated in 4.12.0**)
-- android-support-v4.jar, r27 (**Updated in 5.3.0**)
-- android-support-annotations.jar, r27 (**Updated in 5.3.0**)
-- android-support-v7-recyclerview.jar, r27 (**Updated in 5.3.0**)
+- android-support-v4.jar, r28 (**Updated in 5.4.0**)
+- android-support-annotations.jar, r28 (**Updated in 5.4.0**)
+- android-support-v7-recyclerview.jar, r28 (**Updated in 5.4.0**)
 - MoPub Volley Library (mopub-volley-2.0.0.jar - available on JCenter) (**Updated in 5.0.0**)
 - **Recommended** Google Play Services 15.0.1
 
@@ -144,7 +141,7 @@ Normally, to add the MoPub SDK to your app via JCenter, your `build.gradle` woul
 
 ```	
 dependencies {
-    implementation('com.mopub:mopub-sdk:5.3.0@aar') {
+    implementation('com.mopub:mopub-sdk:5.4.0@aar') {
         transitive = true
     }
 }
@@ -153,7 +150,7 @@ Update to the following to exclude one or both viewability vendors:
 
 ```
 dependencies {
-    implementation('com.mopub:mopub-sdk:5.3.0@aar') {
+    implementation('com.mopub:mopub-sdk:5.4.0@aar') {
         transitive = true
         exclude module: 'libAvid-mopub' // To exclude AVID
         exclude module: 'moat-mobile-app-kit' // To exclude Moat

build.gradle

@@ -1,3 +1,7 @@
+// Copyright 2018 Twitter, Inc.
+// Licensed under the MoPub SDK License Agreement
+// http://www.mopub.com/legal/sdk-license-agreement/
+
 buildscript {
     repositories {
         jcenter()

gradle.properties

@@ -1,2 +1,6 @@
+# Copyright 2018 Twitter, Inc.
+# Licensed under the MoPub SDK License Agreement
+# http://www.mopub.com/legal/sdk-license-agreement/
+
 org.gradle.jvmargs=-Xmx8192m -XX:MaxPermSize=2048m
 org.gradle.daemon=false

gradle/wrapper/gradle-wrapper.properties

@@ -1,3 +1,7 @@
+# Copyright 2018 Twitter, Inc.
+# Licensed under the MoPub SDK License Agreement
+# http://www.mopub.com/legal/sdk-license-agreement/
+
 #Thu Jul 12 13:45:05 PDT 2018
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists

gradlew.bat

@@ -1,3 +1,7 @@
+@rem Copyright 2018 Twitter, Inc.
+@rem Licensed under the MoPub SDK License Agreement
+@rem http://www.mopub.com/legal/sdk-license-agreement/
+
 @if "%DEBUG%" == "" @echo off
 @rem ##########################################################################
 @rem

mopub-sample/AndroidManifest.xml

@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
       package="com.mopub.simpleadsdemo"
-      android:versionCode="63"
-      android:versionName="5.3.0">
+      android:versionCode="64"
+      android:versionName="5.4.0">
 
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />

mopub-sample/build.gradle

@@ -1,3 +1,7 @@
+// Copyright 2018 Twitter, Inc.
+// Licensed under the MoPub SDK License Agreement
+// http://www.mopub.com/legal/sdk-license-agreement/
+
 repositories {
     google()
     jcenter()
@@ -11,17 +15,17 @@ apply plugin: 'com.android.application'
 
 project.group = 'com.mopub'
 project.description = '''MoPub Sample App'''
-project.version = '5.3.0'
+project.version = '5.4.0'
 
 android {
-    compileSdkVersion 27
+    compileSdkVersion 28
     lintOptions { abortOnError false }
 
     defaultConfig {
-        versionCode 63
+        versionCode 64
         versionName version
         minSdkVersion 16
-        targetSdkVersion 27
+        targetSdkVersion 28
     }
 
     buildTypes {
@@ -56,10 +60,10 @@ android {
 }
 
 dependencies {
-    implementation 'com.android.support:customtabs:27.1.1'
-    implementation 'com.android.support:support-v4:27.1.1'
+    implementation 'com.android.support:customtabs:28.0.0'
+    implementation 'com.android.support:support-v4:28.0.0'
     implementation 'com.google.android.gms:play-services-ads:15.0.1'
     implementation 'com.google.android.gms:play-services-base:15.0.1'
-    implementation 'com.android.support:recyclerview-v7:27.1.1'
+    implementation 'com.android.support:recyclerview-v7:28.0.0'
     implementation project(':mopub-sdk')
 }

mopub-sample/project.properties

@@ -1,3 +1,7 @@
+# Copyright 2018 Twitter, Inc.
+# Licensed under the MoPub SDK License Agreement
+# http://www.mopub.com/legal/sdk-license-agreement/
+
 # This file is automatically generated by Android Tools.
 # Do not modify this file -- YOUR CHANGES WILL BE ERASED!
 #

mopub-sample/res/layout/native_ad_list_item.xml

@@ -16,11 +16,12 @@
         android:layout_marginLeft="10dp"
         android:layout_marginStart="10dp"
         android:layout_marginTop="10dp"
-        android:background="@null" />
+        android:background="@null"
+        android:contentDescription="@null" />
 
     <TextView
         android:id="@+id/native_title"
-        android:layout_width="match_parent"
+        android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignParentLeft="true"
         android:layout_alignParentStart="true"
@@ -33,7 +34,7 @@
 
     <TextView
         android:id="@+id/native_text"
-        android:layout_width="match_parent"
+        android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignParentLeft="true"
         android:layout_alignParentStart="true"
@@ -69,6 +70,7 @@
         android:layout_marginRight="10dp"
         android:layout_marginTop="10dp"
         android:clickable="true"
+        android:focusable="true"
         android:paddingBottom="10dp"
         android:text="@string/learn_more"
         android:textColor="@android:color/black"

mopub-sample/res/layout/video_ad_list_item.xml

@@ -16,11 +16,12 @@
         android:layout_marginLeft="10dp"
         android:layout_marginStart="10dp"
         android:layout_marginTop="10dp"
-        android:background="@null" />
+        android:background="@null"
+        android:contentDescription="@null" />
 
     <TextView
         android:id="@+id/native_title"
-        android:layout_width="match_parent"
+        android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignParentLeft="true"
         android:layout_alignParentStart="true"
@@ -33,7 +34,7 @@
 
     <TextView
         android:id="@+id/native_text"
-        android:layout_width="match_parent"
+        android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignParentLeft="true"
         android:layout_alignParentStart="true"
@@ -69,6 +70,7 @@
         android:layout_marginRight="10dp"
         android:layout_marginTop="10dp"
         android:clickable="true"
+        android:focusable="true"
         android:paddingBottom="10dp"
         android:text="@string/learn_more"
         android:textColor="@android:color/black"

mopub-sample/src/main/java/com/mopub/simpleadsdemo/AbstractBannerDetailFragment.java

@@ -1,3 +1,7 @@
+// Copyright 2018 Twitter, Inc.
+// Licensed under the MoPub SDK License Agreement
+// http://www.mopub.com/legal/sdk-license-agreement/
+
 package com.mopub.simpleadsdemo;
 
 import android.os.Bundle;
@@ -46,7 +50,7 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
 
         views.mKeywordsField.setText(getArguments().getString(MoPubListFragment.KEYWORDS_KEY, ""));
         views.mUserDataKeywordsField.setText(getArguments().getString(MoPubListFragment.USER_DATA_KEYWORDS_KEY, ""));
-        hideSoftKeyboard(views.mUserDataKeywordsField);
+        hideSoftKeyboard(views.mKeywordsField);
 
         final String adUnitId = mMoPubSampleAdUnit.getAdUnitId();
         views.mDescriptionView.setText(mMoPubSampleAdUnit.getDescription());

mopub-sample/src/main/java/com/mopub/simpleadsdemo/AdUnitDataSource.java

@@ -1,3 +1,7 @@
+// Copyright 2018 Twitter, Inc.
+// Licensed under the MoPub SDK License Agreement
+// http://www.mopub.com/legal/sdk-license-agreement/
+
 package com.mopub.simpleadsdemo;
 
 import android.content.ContentValues;

mopub-sample/src/main/java/com/mopub/simpleadsdemo/BannerDetailFragment.java

@@ -1,3 +1,7 @@
+// Copyright 2018 Twitter, Inc.
+// Licensed under the MoPub SDK License Agreement
+// http://www.mopub.com/legal/sdk-license-agreement/
+
 package com.mopub.simpleadsdemo;
 
 public class BannerDetailFragment extends AbstractBannerDetailFragment {

mopub-sample/src/main/java/com/mopub/simpleadsdemo/DetailFragmentViewHolder.java

@@ -1,3 +1,7 @@
+// Copyright 2018 Twitter, Inc.
+// Licensed under the MoPub SDK License Agreement
+// http://www.mopub.com/legal/sdk-license-agreement/
+
 package com.mopub.simpleadsdemo;
 
 import android.support.annotation.NonNull;

mopub-sample/src/main/java/com/mopub/simpleadsdemo/InterstitialDetailFragment.java

@@ -1,3 +1,7 @@
+// Copyright 2018 Twitter, Inc.
+// Licensed under the MoPub SDK License Agreement
+// http://www.mopub.com/legal/sdk-license-agreement/
+
 package com.mopub.simpleadsdemo;
 
 import android.os.Bundle;

mopub-sample/src/main/java/com/mopub/simpleadsdemo/LeaderboardDetailFragment.java

@@ -1,3 +1,7 @@
+// Copyright 2018 Twitter, Inc.
+// Licensed under the MoPub SDK License Agreement
+// http://www.mopub.com/legal/sdk-license-agreement/
+
 package com.mopub.simpleadsdemo;
 
 public class LeaderboardDetailFragment extends AbstractBannerDetailFragment {

mopub-sample/src/main/java/com/mopub/simpleadsdemo/LoggingUtils.java

@@ -1,3 +1,7 @@
+// Copyright 2018 Twitter, Inc.
+// Licensed under the MoPub SDK License Agreement
+// http://www.mopub.com/legal/sdk-license-agreement/
+
 package com.mopub.simpleadsdemo;
 
 import android.content.Context;

mopub-sample/src/main/java/com/mopub/simpleadsdemo/MoPubListFragment.java

@@ -1,3 +1,7 @@
+// Copyright 2018 Twitter, Inc.
+// Licensed under the MoPub SDK License Agreement
+// http://www.mopub.com/legal/sdk-license-agreement/
+
 package com.mopub.simpleadsdemo;
 
 import android.app.AlertDialog;

mopub-sample/src/main/java/com/mopub/simpleadsdemo/MoPubSQLiteHelper.java

@@ -1,3 +1,7 @@
+// Copyright 2018 Twitter, Inc.
+// Licensed under the MoPub SDK License Agreement
+// http://www.mopub.com/legal/sdk-license-agreement/
+
 package com.mopub.simpleadsdemo;
 
 import android.content.Context;

mopub-sample/src/main/java/com/mopub/simpleadsdemo/MoPubSampleActivity.java

@@ -1,3 +1,7 @@
+// Copyright 2018 Twitter, Inc.
+// Licensed under the MoPub SDK License Agreement
+// http://www.mopub.com/legal/sdk-license-agreement/
+
 package com.mopub.simpleadsdemo;
 
 import android.annotation.TargetApi;
@@ -52,6 +56,9 @@ private static void setWebDebugging() {
     @Nullable
     PersonalInfoManager mPersonalInfoManager;
 
+    @Nullable
+    private ConsentStatusChangeListener mConsentStatusChangeListener;
+
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
@@ -82,16 +89,27 @@ protected void onCreate(Bundle savedInstanceState) {
                 .build();
         MoPub.initializeSdk(this, sdkConfiguration, initSdkListener());
 
+        mConsentStatusChangeListener = initConsentChangeListener();
         mPersonalInfoManager = MoPub.getPersonalInformationManager();
         if (mPersonalInfoManager != null) {
-            mPersonalInfoManager.subscribeConsentStatusChangeListener(initConsentChangeListener());
+            mPersonalInfoManager.subscribeConsentStatusChangeListener(mConsentStatusChangeListener);
         }
 
         // Intercepts all logs including Level.FINEST so we can show a toast
         // that is not normally user-facing. This is only used for native ads.
         LoggingUtils.enableCanaryLogging(this);
     }
 
+    @Override
+    protected void onDestroy() {
+        if (mPersonalInfoManager != null) {
+            // unsubscribe or memory leak will occur
+            mPersonalInfoManager.unsubscribeConsentStatusChangeListener(mConsentStatusChangeListener);
+        }
+        mConsentStatusChangeListener = null;
+        super.onDestroy();
+    }
+
     private void createMoPubListFragment(@NonNull final Intent intent) {
         if (findViewById(R.id.fragment_container) != null) {
             mMoPubListFragment = new MoPubListFragment();

mopub-sample/src/main/java/com/mopub/simpleadsdemo/MoPubSampleAdUnit.java

@@ -1,3 +1,7 @@
+// Copyright 2018 Twitter, Inc.
+// Licensed under the MoPub SDK License Agreement
+// http://www.mopub.com/legal/sdk-license-agreement/
+
 package com.mopub.simpleadsdemo;
 
 import android.os.Bundle;