Add dynamic TOML support via [DynamicToml] Service #9517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🚀 Updated review app: https://pr-9517-badges-shields.fly.dev |
chris48s
approved these changes
Aug 30, 2023
Mulugruntz
reviewed
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dynamic service for TOML files.
I kept everything as close to the other dynamic services as possible. To be able to use the
BaseTomlServicefrom #9438, I exported in the core where the other base services are exported.For the tests and default values I used the
toml-spec-example.tomlfromsmol-tomlbecausesmol-tomlis used in here and it is the same example TOML file that toml.io shows on their homepage, sadly they do not host this toml themselves.I mostly ported over the test from the dynamic YAML service.