[bitbucketpipelines] resolve "invalid response data" for halted pipelines

[reeceappling]

Should resolve issue #9096
Bitbucket responses for pipelines in progress will now fall back to utilizing the stage name instead of being invalid.

[github-actions]

	Messages
📖	✨ Thanks for your contribution to Shields, @reeceappling!

Generated by 🚫 dangerJS against 73e4a4b

[reeceappling]

It appears to be failing due to some missing credentials. Not sure what needs to be done about that...

[calebcartwright]

Thanks for the PR!

It appears to be failing due to some missing credentials. Not sure what needs to be done about that...

in CI we funnel the test output to a different area where it's easier to consume, the console output about the credentials is unrelated. You can find the test failures in the summary for the PR at https://github.com/badges/shields/actions/runs/5843476444/attempts/1#summary-15845658997, and imo from a quick glance, the failures do seem highly likely related to the proposed changes.

[reeceappling]

Sweet, thanks for the explaination, I'll have time to check it out tomorrow.

[chris48s]

I think this PR does introduce a failure.

But also unfortunately Bitbucket does have some failing tests anyway, so we are not starting from a point where everything passes with this one.

I've updated the PR title to only run the tests for BB pipelines. Lets take failing issues tests out of the equation as they're not being touched here.

The baseline for this service is

• 9 passing
• 2 failing

with the failures on

• Bitbucket Pipelines [live] branch build result (valid)
• Bitbucket Pipelines [live] branch build result (never built)

because the upstream repo we were testing against has been deleted. To fix those, we need to find or make another repo for those tests, or switch them to mocked tests.

so I think for this PR if we can keep everything else passing that is OK for review.

[PyvesB]

@reeceappling I spent some time fixing all Bitbucket tests in #9881, it should help you out if you were to revive this PR. :)

[PyvesB]

Given that there hasn't been any activity for a while, I'm going to close this pull request. Feel free to ping us or reopen it if you get a chance to look into it again. 😉

If others think that repository level projects would be an option and want to pick this up, you can simply fetch the commits by running git fetch origin pull/9472/head:pr-9472. Change the implementation to target repository level projects and open a new pull request with a co-authored trailer included in the commit message to give attribution to the original author.