Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added [GitLabTag] service #6389

Closed
wants to merge 3 commits into from
Closed

Conversation

guillermin
Copy link

Added GitLab Tag (latest by date) service, equivalent to GitHub Tag (latest by date) but for gitlab.com instead of github.com.

I created issue #6388 for this, but it is closed as a duplicate of #4867 (which asks to replicate all GitHub Tags and Releases services for GitLab. Right now my priority is this badge, but I promise to to include the rest in the future.

@shields-ci
Copy link

shields-ci commented Apr 16, 2021

Messages
📖 ✨ Thanks for your contribution to Shields, @guillermin!

Generated by 🚫 dangerJS against 0f308ee

@PyvesB PyvesB added the service-badge New or updated service badge label Apr 18, 2021
@PyvesB
Copy link
Member

PyvesB commented Apr 18, 2021

Hello @guillermin! 👋🏻

Thanks for opening this. Unfortunately, we don't intend on expanding our GitLab badge offering at this point in time, due to API rate limit concerns. Right now, the badge you've implemented would probably fail most of the time on our production servers due to these limitations. See #541 (comment) and various other messages for a bit more context. 😉

@calebcartwright calebcartwright added the on-hold Deferred in favor of another approach, blocked on preceding efforts, stale, or abandoned label May 2, 2021
@PyvesB
Copy link
Member

PyvesB commented May 25, 2021

Due to aforementioned API rate limiting concerns, I don't see a path forward with this pull request for the time being. Thanks for sharing your code, but I'm afraid I'll have to close it for now.

The next steps for any Gitlab badge using the official API would be to engage in #541 and help us figure out the state of the access token features offered by Gitlab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold Deferred in favor of another approach, blocked on preceding efforts, stale, or abandoned service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants