Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix REQUIRE_CLOUDFLARE for Heroku #5712

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Fix REQUIRE_CLOUDFLARE for Heroku #5712

merged 3 commits into from
Oct 15, 2020

Conversation

paulmelnikow
Copy link
Member

I tested this on staging and it seems to work as intended!

Ref #3027

@paulmelnikow paulmelnikow added operations Hosting, monitoring, and reliability for the production badge servers core Server, BaseService, GitHub auth, Shared helpers labels Oct 15, 2020
@shields-ci
Copy link

shields-ci commented Oct 15, 2020 •
edited
Loading

Warnings
⚠️ This PR modified the server but none of its tests.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against df8480c

@paulmelnikow paulmelnikow requested a deployment to shields-staging-pr-5712 October 15, 2020 23:23 Abandoned
@paulmelnikow paulmelnikow merged commit cbd8eba into master Oct 15, 2020
@paulmelnikow paulmelnikow deleted the cloudflare-debug branch October 15, 2020 23:27
@github-actions
Copy link
Contributor

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@chris48s chris48s mentioned this pull request Oct 25, 2020
Closed
@chris48s chris48s mentioned this pull request Apr 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers operations Hosting, monitoring, and reliability for the production badge servers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulmelnikow @shields-ci @calebcartwright @shields-cd