Support for Bintray version badge. #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #58 by supporting a badge showing the latest version of a Bintray package.
| if (serverSecrets && serverSecrets.bintray_user) { | ||
| options.auth = { | ||
| user: serverSecrets.bintray_user, | ||
| pass: serverSecrets.bintray_apikey |
There was a problem hiding this comment.
The use of those credentials seem unfortunately necessary. I have created a BinTray account, but I cannot find where in my profile page I get the API key.
It is similarly unfortunate that the rate limit is so low, we'll see what consequences that has, pending that I find the API key.
There was a problem hiding this comment.
It's in a strange place. If you edit your profile there's an API key section.
|
Thanks a lot! |
|
Thanks for merging! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #58 by supporting a badge showing the latest version of
a Bintray package.
Ran a test locally and it seemed to work fine. You'd need to get an API key from Bintray to put in
secret.jsonand work with them on the rate limit question.