Consolidate [NpmDownloads] into one service #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the four npm download services into a single class, in line with #3174, and other service implementations we've written in the last couple months.
|
paulmelnikow
commented
Apr 16, 2019
| return this.constructor.render({ downloads }) | ||
| } | ||
| async handle({ interval, scope, packageName }) { | ||
| const { query, schema, transform } = intervalMap[interval] |
There was a problem hiding this comment.
I like using destructuring here. It makes this code particularly readable and I think a bit less error prone.
There was a problem hiding this comment.
👍 I like this a lot too
| dm: { | ||
| query: 'point/last-month', | ||
| schema: pointResponseSchema, | ||
| transform: json => json.downloads, |
There was a problem hiding this comment.
A little bit of repetition here, though it helps with clarity.
| } | ||
| } | ||
| // For testing. | ||
| static get _intervalMap() { |
There was a problem hiding this comment.
Good idea! This makes things easy to test without having to define (and unnecessarily call) a class level render/transform function
calebcartwright
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the four npm download services into a single class, in line with #3174, and other service implementations we've written in the last couple months.
intervalMappattern that I think @calebcartwright started us using.