Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious truthiness checks on serverSecrets #2634

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

paulmelnikow
Copy link
Member

serverSecrets is always truthy.

Close #2606

`serverSecrets` is always truthy.

Close #2606
@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Jan 4, 2019
@shields-ci
Copy link

Warnings
⚠️ This PR modified service code for bintray but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for sonarqube but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

📚 Remember to ensure any changes to serverSecrets in services/jenkins/jenkins-coverage.service.js are reflected in the server secrets documentation

⚠️

📚 Remember to ensure any changes to serverSecrets in services/jira/jira-base.js are reflected in the server secrets documentation

⚠️ This PR modified service code for sensiolabs but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

📚 Remember to ensure any changes to serverSecrets in services/sonarqube/sonarqube.service.js are reflected in the server secrets documentation

⚠️

📚 Remember to ensure any changes to serverSecrets in services/jenkins/jenkins-tests.service.js are reflected in the server secrets documentation

⚠️

📚 Remember to ensure any changes to serverSecrets in services/sensiolabs/sensiolabs.service.js are reflected in the server secrets documentation

⚠️

📚 Remember to ensure any changes to serverSecrets in services/azure-devops/azure-devops-helpers.js are reflected in the server secrets documentation

⚠️

📚 Remember to ensure any changes to serverSecrets in services/bintray/bintray.service.js are reflected in the server secrets documentation

⚠️ This PR modified service code for nexus but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

📚 Remember to ensure any changes to serverSecrets in services/teamcity/teamcity-base.js are reflected in the server secrets documentation

⚠️ This PR modified service code for jenkins but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

📚 Remember to ensure any changes to serverSecrets in services/nexus/nexus.service.js are reflected in the server secrets documentation

⚠️

📚 Remember to ensure any changes to serverSecrets in services/jenkins/jenkins-build.service.js are reflected in the server secrets documentation

Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 0a5a9dd

@paulmelnikow paulmelnikow merged commit 5233a25 into master Jan 4, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants