Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert a bunch of exampleUrls and formats [ansible bitrise circleci clojars codacy codeclimate codecov depfu discord] #2633

Merged
merged 7 commits into from
Jan 5, 2019
Merged

Convert a bunch of exampleUrls and formats [ansible bitrise circleci clojars codacy codeclimate codecov depfu discord] #2633

merged 7 commits into from
Jan 5, 2019

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Jan 4, 2019 •
edited
Loading

In addition to the service tests, these should be verified in the UI.

@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Jan 4, 2019
@shields-ci
Copy link

shields-ci commented Jan 4, 2019 •
edited
Loading

Warnings
⚠️ This PR modified service code for ansible but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cdnjs but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for circleci but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for clojars but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bitrise but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for codeclimate but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for codecov but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for ctan but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for depfu but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for discord but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for codacy but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 2d5bbec

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2633 January 4, 2019 17:50 Inactive
calebcartwright
calebcartwright reviewed Jan 5, 2019
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor items added inline below

services/bitrise/bitrise.service.js Show resolved Hide resolved
services/clojars/clojars-downloads.service.js Outdated Show resolved Hide resolved
services/clojars/clojars-version.service.js Outdated Show resolved Hide resolved
services/codecov/codecov.service.js Show resolved Hide resolved
@calebcartwright
Copy link
Member

Just as an aside on the clojars-version service..

The behavior here is the same as before, but is the badge message here what we'd expect for a version badge?

https://img.shields.io/clojars/v/prismic.svg

I would've expected the message to be 1.1 vs. [ prismic "1.1" ]

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2633 January 5, 2019 19:47 Inactive
@paulmelnikow
Copy link
Member Author

The behavior here is the same as before, but is the badge message here what we'd expect for a version badge?

That badge has an unusual format. I don't use clojure though I suspect the badge message is in a format that can be pasted into a CLI or config file.

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2633 January 5, 2019 19:50 Inactive
@paulmelnikow paulmelnikow merged commit c4143b9 into master Jan 5, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the example-urls branch January 5, 2019 19:54
@chris48s
Copy link
Member

chris48s commented Jan 5, 2019

Clojars does have a legitimately unusual version format - see #431

@calebcartwright
Copy link
Member

Ahh okay that makes more sense now, thanks @chris48s!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulmelnikow @shields-ci @calebcartwright @chris48s