Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirectUrl: Update terminology and add a test #2617

Merged
merged 2 commits into from
Jan 2, 2019
Merged

redirectUrl: Update terminology and add a test #2617

merged 2 commits into from
Jan 2, 2019

Conversation

paulmelnikow
Copy link
Member

No description provided.

@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth, Shared helpers label Jan 2, 2019
@shields-ci
Copy link

shields-ci commented Jan 2, 2019 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 28ae1fd

platan
platan approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@platan platan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Do you have a plan to change process.env.REDIRECT_URI to redirectUrl: process.env.REDIRECT_URL and baseUri to baseUrl in the future?

@paulmelnikow
Copy link
Member Author

We've been standardizing on "url", so yea, baseUri should get changed too.

Changing the environment variable names is fine too, though I want to get #2621 resolved before messing with them too much.

@paulmelnikow paulmelnikow merged commit 5dc25af into master Jan 2, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the test-redirect-root branch January 2, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platan platan platan approved these changes

Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmelnikow @shields-ci @platan