Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test of the server entrypoint #2613

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Add test of the server entrypoint #2613

merged 2 commits into from
Jan 2, 2019

Conversation

paulmelnikow
Copy link
Member

The server's entrypoint is an important bit of code which is not covered by our tests. This adds a test which should cover it.

@paulmelnikow
Add test of the server entrypoint
051ff22 
The server's entrypoint is an important bit of code which is not covered by our tests. This adds a test which should cover it.
@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth, Shared helpers label Jan 2, 2019
@shields-ci
Copy link

shields-ci commented Jan 2, 2019 •
edited
Loading

Warnings
⚠️

This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?
⚠️ This PR modified the server but none of its tests.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 1537521

@paulmelnikow paulmelnikow merged commit 7150b37 into master Jan 2, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the test-entrypoint branch January 9, 2019 17:30
@platan platan mentioned this pull request Apr 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmelnikow @shields-ci @calebcartwright