Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register missing redirects [static] #2603

Merged
merged 2 commits into from
Dec 28, 2018
Merged

Register missing redirects [static] #2603

merged 2 commits into from
Dec 28, 2018

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Dec 28, 2018 •
edited
Loading

This call was missed in #2519.

@paulmelnikow paulmelnikow added bug Bugs in badges and the frontend service-badge New or updated service badge keep-service-tests-green Related to fixing failing tests of the services labels Dec 28, 2018
@shields-ci
Copy link

shields-ci commented Dec 28, 2018 •
edited
Loading

Warnings
⚠️

This PR modified helper functions in lib/ but not accompanying tests.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 11c2a43

@paulmelnikow paulmelnikow merged commit ebe6da2 into master Dec 28, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the register-redirects branch December 29, 2018 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
bug Bugs in badges and the frontend keep-service-tests-green Related to fixing failing tests of the services service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmelnikow @shields-ci @calebcartwright