refactor [TeamCity] #2601
Merged
refactor [TeamCity] #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
calebcartwright
commented
Dec 28, 2018
| pass: serverSecrets.teamcity_pass, | ||
| } | ||
| } else { | ||
| qs.guest = 1 |
There was a problem hiding this comment.
TeamCity requires auth, so if explicit user/pass are not provided then we have to use guest auth
calebcartwright
commented
Dec 28, 2018
| sendBadge(format, badgeData) | ||
| } | ||
| const buildStatusRegex = /SUCCESS|FAILURE|ERROR/ | ||
| const buildStatusTextRegex = /^Success|Failure|Error|Tests( failed: \d+( \(\d+ new\))?)?(,)?( passed: \d+)?(,)?( ignored: \d+)?(,)?( muted: \d+)?$/ |
There was a problem hiding this comment.
This covers everything that I've seen, but I have this suspicion that there are other potential values. The API spec does not enumerate those potential values so this is based on available info.
calebcartwright
commented
Dec 28, 2018
| } | ||
| } | ||
|
|
||
| static get examples() { | ||
| return [ | ||
| { | ||
| title: 'TeamCity CodeBetter', | ||
| previewUrl: 'codebetter/bt428', | ||
| title: 'TeamCity Build Status (CodeBetter)', |
There was a problem hiding this comment.
CodeBetter was apparently merged with the main teamcity.jetbrains.com Open Source instance (see http://codebetter.jetbrains.com/) but maintaining the path and some nomenclature for backwards compatibility
|
Review app deployment is failing, heroku logs here: |
|
Hmm, are there more logs further up? (Probably related to #2569.) |
|
Nope, at least not that I could see in the dashboard. Will check with the CLI to see if that offers any more insight |
|
From the CLI |
|
Alright I think I've figured out what's going on here: In This results in It looks like there's a couple relatively easy fixes to this, but I'm hesitant to update this just yet as I'm not familiar with the server config/startup process. Any thoughts? |
|
I think this is unrelated to this PR. I tried to create a review app for #2598 and I've got the same issue: https://shields-staging-pr-2598.herokuapp.com/ Failing with Sounds like you're on the right lines for a fix, but given the issue isn't strictly related to this PR and is affecting other staging deploys, can we pull the fix out into a new PR so we can review it independently of the TeamCity refactor. Then we can merge it into other affected working branches. |
|
Proposed fix in #2607 for review |
|
Looks like the fix is working |
paulmelnikow
reviewed
Jan 2, 2019
paulmelnikow
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors TeamCity services to new service model and adds tests.
Refs #1358