Split up [github] testers #2560
Conversation
paulmelnikow
added
service-badge
|
| @@ -42,7 +42,6 @@ module.exports = class GithubContributors extends LegacyService { | |||
| message: '397', | |||
| color: 'blue', | |||
| }, | |||
| keywords: ['GitHub', 'contributor'], | |||
There was a problem hiding this comment.
More of a question as I'm not familiar with search, but does it do partial word matches? I.e. will contributor still be matched in search since the title contains contributors?
There was a problem hiding this comment.
Yea. I think it matches on leading substrings:
| const t = (module.exports = require('../create-service-tester')()) | ||
|
|
||
| t.create('hit counter') | ||
| .get('/torvalds/linux/goto.json') |
There was a problem hiding this comment.
This isn't related to the refactored tests in this PR but the GH Search hit counter badge isn't rendering for me in the staging deploy env. You mentioned in #1358 (comment) that perhaps it is just that particular repo that is slow, so would it be worth using a different repo for this test?
There was a problem hiding this comment.
Yea, I think it would. Perhaps we should also update the example, which is what renders in the staging deploy.
One of the open issues PRs also tends to time out. I think it's the undefined label test. We could try it on a smaller repo or give it a longer timeout.
I try to avoid changing things while they're being moved because it's hard to compare what's changed, so let's handle this in a follow-on.
create-service-tester.Conflicts nominally with #2470. Let's merge that ASAP and this right afterward so as to unblock the rest of #2320.