Add static examples for [Node] #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
chris48s
reviewed
Dec 1, 2018
services/node/node.service.js
Outdated
| }, | ||
| ] | ||
| } | ||
|
|
||
| static renderStaticExample({ tag, nodeVersionRange }) { | ||
| // This should match the behavior of `async render()`, which is enforced | ||
| // with a unit test. |
There was a problem hiding this comment.
It took me a while to work out that the reason why we have to do this non-standard thing is because render() has to call an async function but we need this to be a synchronous call. Can we make this extra clear in the comment here.
There was a problem hiding this comment.
I updated the comment. See if that's clearer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1961