Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce property shorthand #2243

Merged
merged 3 commits into from
Nov 1, 2018
Merged

Enforce property shorthand #2243

merged 3 commits into from
Nov 1, 2018

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Oct 31, 2018 •
edited
Loading

I had to track down the right lint rule for this. We have no-useless-rename for destructuring and import/export. The one for object literals is object-shorthand.

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Oct 31, 2018
chris48s
chris48s previously approved these changes Oct 31, 2018
View reviewed changes
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2243 October 31, 2018 21:26 Inactive
@shields-ci
Copy link

Warnings
⚠️

This PR modified helper functions in lib/ but not accompanying tests.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for gem but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for hexpm but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for imagelayers but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for jenkins but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for aur but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for requires but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for steam but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for swagger but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for wercker but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for wordpress but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for librariesio but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖

✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

@paulmelnikow paulmelnikow merged commit 07b282f into master Nov 1, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the object-shorthand branch November 1, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platan platan platan approved these changes

@chris48s chris48s chris48s left review comments

Assignees
No one assigned
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulmelnikow @shields-ci @platan @chris48s