Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce using async-await [f-droid] #2241

Merged
merged 7 commits into from
Nov 4, 2018
Merged

Enforce using async-await [f-droid] #2241

merged 7 commits into from
Nov 4, 2018

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Oct 31, 2018 •
edited
Loading

Re: #2028

Note: Lint will fail until #2029 is merged.

@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Oct 31, 2018
@shields-ci
Copy link

shields-ci commented Oct 31, 2018 •
edited
Loading

Warnings
⚠️

This PR modified helper functions in lib/ but not accompanying tests.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for chrome-web-store but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for f-droid but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for php-eye but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for travis but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖

✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2241 October 31, 2018 03:25 Inactive
@paulmelnikow paulmelnikow changed the title Minor: Use async-await in [f-droid] Enforce using async-await [f-droid] Oct 31, 2018
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2241 October 31, 2018 03:26 Inactive
@niccokunzmann
Copy link
Contributor

Interesting. I learned something from this: "await"

chris48s
chris48s previously approved these changes Oct 31, 2018
View reviewed changes
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2241 October 31, 2018 21:19 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2241 October 31, 2018 21:23 Inactive
@paulmelnikow
Copy link
Member Author

The suggest code has a then which needed another eslint-disable, so this will need another 👍.

chris48s
chris48s previously approved these changes Nov 1, 2018
View reviewed changes
@paulmelnikow
Copy link
Member Author

This will conflict with #2242. Let's merge that in first.

@paulmelnikow paulmelnikow merged commit d55e1c1 into master Nov 4, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the async-await-2 branch November 4, 2018 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulmelnikow @shields-ci @niccokunzmann @chris48s