fix [sonar] legacy/unsupported service tests #1741
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service tests for
have been failing consistently on the daily build for some time. It looks like their API now only returns the error response over HTTPS and times out over HTTP:
Hence
https://img.shields.io/sonar/4.2/https/sonarqube.com/com.github.dannil:scb-java-client/tech_debt.svg does render a badge:
but https://img.shields.io/sonar/4.2/http/sonarqube.com/com.github.dannil:scb-java-client/tech_debt.svg will time out:
Not sure why this is. I think the outputs we produce here are correct given the API behaviour so I propose just updating the 2 tests.