Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [sonar] legacy/unsupported service tests #1741

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

chris48s
Copy link
Member

The service tests for

  • Tech Debt (legacy API unsupported)
  • Coverage (legacy API unsupported)

have been failing consistently on the daily build for some time. It looks like their API now only returns the error response over HTTPS and times out over HTTP:

$ curl "https://sonarqube.com/api/resources?resource=com.github.dannil:scb-java-client&depth=0&metrics=sqale_debt_ratio&includetrends=true"
{"errors":[{"msg":"Unknown url : /api/resources"}]}

$ curl "http://sonarqube.com/api/resources?resource=com.github.dannil:scb-java-client&depth=0&metrics=sqale_debt_ratio&includetrends=true"
curl: (7) Failed to connect to sonarqube.com port 80: Connection timed out

Hence

https://img.shields.io/sonar/4.2/https/sonarqube.com/com.github.dannil:scb-java-client/tech_debt.svg does render a badge:

but https://img.shields.io/sonar/4.2/http/sonarqube.com/com.github.dannil:scb-java-client/tech_debt.svg will time out:

Not sure why this is. I think the outputs we produce here are correct given the API behaviour so I propose just updating the 2 tests.

@shields-ci
Copy link

Messages
📖

✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS

@RedSparr0w
Copy link
Member

Nice catch, looks to be the best course of action.

@chris48s chris48s merged commit def1bc3 into badges:master Jun 18, 2018
@shields-deployment
Copy link

shields-deployment bot commented Jun 18, 2018

This pull request was merged to master branch. Now this change is waiting for deployment.
Deploys usually happen every few weeks. After deployment changes are copied to gh-pages branch.

This badge displays deployment status:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants