Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test path escaping #1627

Merged
merged 1 commit into from
Apr 1, 2018
Merged

Test path escaping #1627

merged 1 commit into from
Apr 1, 2018

Conversation

RedSparr0w
Copy link
Member

This PR changes the single quote marks ' to escaped double qoutes \"

refer: mochajs/mocha#2895 (comment)
npm run test:js:server returns:

Warning: Could not find any test files matching pattern: '*.spec.js'
Warning: Could not find any test files matching pattern: 'lib/**/*.spec.js'
Warning: Could not find any test files matching pattern: 'services/**/*.spec.js'

@shields-ci
Copy link

Warnings
⚠️

This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?

Messages
📖

✨ Thanks for your contribution to Shields, @RedSparr0w!

Generated by 🚫 dangerJS

Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha, I was having the same problem myself for some time, and I thought it was just due to the fact that I was using a rather "exotic" command line tool and setup on my Windows. This seems to solve the problem. Well done! 👍

@RedSparr0w RedSparr0w merged commit 57008d2 into badges:master Apr 1, 2018
@RedSparr0w
Copy link
Member Author

Thanks, Yeah i always just assumed it was just something wrong on my end 😆

@RedSparr0w RedSparr0w deleted the mocha_fix branch January 21, 2019 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants