Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docker build by upgrading glob to be a prod dependency #1619

Merged
merged 1 commit into from
Mar 28, 2018
Merged

Fix Docker build by upgrading glob to be a prod dependency #1619

merged 1 commit into from
Mar 28, 2018

Conversation

philipithomas
Copy link
Contributor

Closes #1618

@shields-ci
Copy link

Warnings
⚠️

This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?
Messages
📖

✨ Thanks for your contribution to Shields, @philipithomas!

Generated by 🚫 dangerJS

@paulmelnikow
Copy link
Member

Thanks! This was definitely an oversight!

@paulmelnikow paulmelnikow added bug Bugs in badges and the frontend core Server, BaseService, GitHub auth, Shared helpers labels Mar 28, 2018
@paulmelnikow paulmelnikow merged commit 01646de into badges:master Mar 28, 2018
@paulmelnikow paulmelnikow mentioned this pull request Apr 2, 2018
Merged
@paulmelnikow
Copy link
Member

I inadvertently merged this without updates to package-lock. Opened #1633 to fix that.

paulmelnikow added a commit that referenced this pull request Apr 2, 2018
@paulmelnikow
package-lock fixes for glob (#1633)
f9b0aed 
Missing from #1619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs in badges and the frontend core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipithomas @shields-ci @paulmelnikow