Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseService: Query params #1589

Merged
merged 10 commits into from
Jun 16, 2018
Merged

BaseService: Query params #1589

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bc91cc6
Add tests for BaseService
paulmelnikow Mar 19, 2018
2abe6d7
Handle query params
paulmelnikow Mar 19, 2018
c9fc89d
Merge branch 'master' into query-params
paulmelnikow Mar 20, 2018
2cb4b0b
Add doc
paulmelnikow Mar 20, 2018
274d11e
Merge branch 'master' into query-params
paulmelnikow Mar 21, 2018
3bc185e
Merge branch 'master' into query-params
paulmelnikow Apr 2, 2018
e1c394d
Fix syntax
paulmelnikow Apr 2, 2018
c2953fd
Merge branch 'master' into query-params
paulmelnikow Apr 2, 2018
89e940d
Merge branch 'master' into query-params
paulmelnikow Jun 16, 2018
bba0041
Several fixes for readability, uri -> url
paulmelnikow Jun 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix syntax
  • Loading branch information
@paulmelnikow
paulmelnikow committed Apr 2, 2018
commit e1c394dad2653ab65110c81067c44fa588e88e41
2 changes: 1 addition & 1 deletion services/base.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class DummyService extends BaseService {
return {
base: 'foo',
format: '([^/]+)',
capture: ['someArg']
capture: ['someArg'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename someArg to namedArgA (or namedArg1).

queryParams: ['suffix'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename suffix to queryParamA?

};
}
Expand Down