-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logo style badges #1478
Add logo style badges #1478
Conversation
add new styles: - flat-logo - flat-square-logo
Generated by 🚫 dangerJS |
Wow, neat, these are really cute! I wonder if anyone else would like to weigh in on the design. Did you experiment with the logo centered over the bar instead of at the top? I wonder how that would look. |
lib/supported-features.js
Outdated
@@ -5,6 +5,8 @@ const advertisedStyles = [ | |||
'flat', | |||
'flat-square', | |||
'for-the-badge', | |||
'flat-logo', | |||
'flat-square-logo', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think popout
and popout-square
might be clearer names for these formats?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good idea, i couldn't think of what to call them, but popout
is a great choice.
flat-logo -> popout flat-square-logo -> popout-square
Never thought of that, |
Not sure which ones I prefer either. When it comes to objects or geometric logos, the centered ones look better in my opinion, but for instance you get the impression that the Linux penguin is "sitting" on the badge, it's quite quite a neat effect as well. Possibly we could give users two options |
They are pretty, but.... seems to break the non-promotional mission statement of the project |
I like the penguin sitting on the floor! For all the rest I prefer the centered. Let's definitely support that one. Actually, I'd be curious to see what the penguin looks like centered. If it looks decent I would say, let's support centered and not floored. If it looks bad, and you're up for doing the work, we could support both logo placement options. It might be better for the user to choose between them using a parameter like
That's true of all the logos. I don't think we're veering so far afield by supporting these. |
How about Or Penguin looks cuter at |
I like your examples better! While technically it's true that the badge is moving, I don't think people will necessarily see it that way. Since it goes with the |
That sign for
Agreed! |
I've reversed |
Making this change in const logo = style.startsWith('popout') ? 'data:something-cool-here' : undefined;
const badgeUri = staticBadgeUrl(
baseUri,
'style',
style,
'green',
{ longCache, style, logo }); I'm wondering though, if we should add a separate heading, and show a few examples showing logos, so people are seeing e.g. flag-square, social, and also popout. That way, people are less likely to conflate a badge with a logo with popout. |
We should get this merged! Is it just waiting for usage instructions to be updated? |
If it is just usage, let's merge it, and then add the docs in a follow-on PR. |
Missed your last comment sorry, |
All working with latest changes merged. |
Do we really seriously honestly need to keep adding exotic styles like this? The inbalance in the design due to the logos breaking out of the container means that these are going to be a mess on any page that includes more than one of them. This project is not an emoji or trading card collection, it's a serious attempt at meaningful standardization of metadata for open source projects. It's a regression to the exact issue that prompted me to create Shields in the first place: inconsistency, visual noise for no other purpose than being louder than other badges, all in service of a superficial aesthetic pursuit that frankly looks shoddy most of the time. Sorry if this feels like a strong diss, and I know the project is in your care now @paulmelnikow but at the risk of looking like I'm swooping in after everyone's done with the hard work, I wish we could put our collective foot down on these alternative designs. Paralysis of choice is a real problem. Offering a million design alternatives means that we're destroying the useful standardization we've worked so hard to achieve for years. Let's be brave and deprecate designs if we believe we've found a better one, but at this cadence we'll have 30 different styles in a few years and we'll be back in a visual mess where badges are shouting against each other for attention rather than showcasing useful information at a glance in a succinct a clear manner. |
Hi Olivier, thanks for sharing that post! Most of what I’ve learned about the origin of this project has been through issue discussion and I'd never actually seen that. (We should link to it from the history section, and also expand that with whatever else you can think to add.) I appreciate your input that Shields should offer less customization. I didn’t push back in this instance, though I often do, and tend feel like the sole voice. It’s important for its sustainability that Shields be community-driven. While I see badges as a bit more "serious" and tend to aim for consistency and very limited customizability (a la Apple), some users are badge lovers who come here to make their open-source work more fun. Some of them do want emoji and trading cards. I'd tend to think this project is large enough for both perspectives that fractionalization would make things even more divergent… so I steer toward consistency, but don't impose it. I welcome the discussion. Among @RedSparr0w’s other contributions as a maintainer (perhaps most impactful being the dynamic badge) he’s put a lot into maintaining both the templates and logos. In two years he's added two new styles, so we’re not on a slippery slope to offering dozens of them. We document the styles but don’t push them, so I don’t perceive paralysis of choice being a huge concern. I’m open to revisiting this style – which I haven't seen used in the wild – and the styles and design in general. I’ve been meaning to propose changing the default to Something else that could have a big impact on the signal-to-noise ratio of badges would be a “badge best practices” page for developers. Amazingly, there has been some serious research done about badges + projects based on signaling theory and gamification: Developers are meritocratic by nature and I imagine would be persuaded by that kind of research, and I think it would be an ideal place to convey the principles behind the Shields origin-vision and encourage them to play along. Along the way, we could give good examples of customization, guiding them how best to use the choice they have. |
@paulmelnikow I'm so glad you're shepherding this project. Apologies to @RedSparr0w for the drive-by cranky post. I realize I'm singling you out to make a point and that can't feel fair when you've worked your ass off. The last thing I want is to add some gatekeeping antics to this healthy blossoming community. I love your suggestion for best practices @paulmelnikow. This is basically what I moved toward with https://keepachangelog.com/. I'm really hopeful the generator ideas related to the #1899 redesign will facilitate this, since it would make sense to guide people through the process of creating quality badges. I could swear there was an old discussion somewhere around changing the default to flat when flat design started becoming real trendy. Yep, there is is. It's my job to make sure the original rationale behind Shields is clear and documented. I think we had it in the original repo and it might have gotten lost in the weeds of time. Here are some fun historical items I managed to dig back up:
|
No worries, I definitely understand your point of view, and if we decide to downsize the current styles i'm fine with that.
👍
It would be great if we had some metrics on the styles of badges being used.
The main kind of use case I imagined with this badge would have been something similar to:My Project Downloads:Something ElseLorem ipsum dolor sit amet, consectetur adipiscing elit. Suspendisse non sem enim. Suspendisse vitae nisl aliquet, laoreet erat quis, blandit turpis. Mauris vel luctus diam. Duis neque quam, ornare vel aliquam et, tristique quis risus. In tincidunt enim a sapien suscipit, ut malesuada tortor iaculis. Proin cursus, tortor vel commodo. Donate:Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam in pellentesque est. Nullam elementum leo at tempor dictum. Donec commodo commodo mauris ut laoreet. Curabitur. -END-Similarly with the I guess the thing to decide now is where we go from here, |
This PR adds 2 new style badges which emphasize the logo on the badge:
popout
popout-square
These allow for a query parameter called
logoPosition
:(By default the logo is centered)
negative numbers moves the badge down/logo up:
-5
:positive numbers move the badge up/logo down:
5
:If a logo is not specified it will automatically fallback to serve the
flat
orflat-square
style badgeExamples:
popout
popout-square