Add [twitter] tests #1394
Merged
Add [twitter] tests #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inaccessable | 404 etc invalid user | no data returned from endpoint invalid | error thrown
Generated by 🚫 dangerJS |
RedSparr0w
force-pushed
the
twitter-test
branch
from
38071f0
to
df166cd
Compare
RedSparr0w
force-pushed
the
twitter-test
branch
from
5f886a1
to
03c233e
Compare
RedSparr0w
force-pushed
the
twitter-test
branch
from
03c233e
to
d16a115
Compare
|
Full coverage except for when |
paulmelnikow
approved these changes
Dec 28, 2017
|
|
||
| t.create('URL') | ||
| .get('/url/https/shields.io.json') | ||
| .expectJSON({ name: 'tweet', value: '' }); |
There was a problem hiding this comment.
This is a confusing badge URL!
There was a problem hiding this comment.
Yeah, Don't think it would be a very often used badge,
As it would need to be included as an <object> for the link to actually work.
Otherwise its the same as using 
https://img.shields.io/:tweet--grey.svg?style=social&logo=twitter
Will be good once we can get #966 implemented to see how often certain badges are being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for twitter,
Add error handling messages to right hand side of badge:
invalid,inaccessible,invalid user