Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github auth admin endpoint and logging #1267

Merged
merged 7 commits into from
Nov 30, 2017
Merged

Github auth admin endpoint and logging #1267

merged 7 commits into from
Nov 30, 2017

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Nov 10, 2017 •
edited
Loading

  • Periodically log github auth information
    • Tokens are hashed which reduces the security risk inherent in the logs
      • A consistent hash is used so tokens can be correlated across the three data structures and across the three servers
  • Add an admin endpoint for github auth information
    • Tokens are returned as-is to enable troubleshooting (e.g. comparing our reqRemaining to github’s)

@paulmelnikow
Github auth debug endpoint and logging
fa96190 
- Periodically log github auth information
    - Tokens are hashed which reduces the security of the logs
        - A consistent hash is used so tokens can be correlated across the three data structures
- Add an authenticated endpoint for github auth information
    - Tokens are returned as-is to enable troubleshooting (e.g. comparing our reqRemaining to github’s)
@paulmelnikow paulmelnikow added operations Hosting, monitoring, and reliability for the production badge servers core Server, BaseService, GitHub auth, Shared helpers labels Nov 10, 2017
@paulmelnikow paulmelnikow mentioned this pull request Nov 10, 2017
Closed
@paulmelnikow paulmelnikow changed the title Github auth debug endpoint and logging Github auth admin endpoint and logging Nov 30, 2017
@paulmelnikow paulmelnikow merged commit 127b46a into badges:master Nov 30, 2017
@paulmelnikow paulmelnikow deleted the github-debug-logging branch November 30, 2017 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers operations Hosting, monitoring, and reliability for the production badge servers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paulmelnikow