Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Github OAuth error again #1244

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Fix Github OAuth error again #1244

merged 1 commit into from
Nov 2, 2017

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Nov 2, 2017 •
edited
Loading

This fix #1243, a merge error introduced in #1118.

This line went out:

const baseUrl = process.env.BASE_URL || 'https://img.shields.io';

And this one went in:

const baseUrl = process.env.BASE_URL || 'https://shields.io';

@paulmelnikow
Copy link
Member Author

The build error was caused by vendor | unresponsive while running service tests, which is a problem, but not with this code.

@paulmelnikow paulmelnikow merged commit 4d22799 into badges:master Nov 2, 2017
@paulmelnikow paulmelnikow deleted the fix-github-tokens branch November 2, 2017 14:35
@snyk-bot snyk-bot mentioned this pull request Jan 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"GitHub OAuth authentication failed to provide a code" when adding token
1 participant
@paulmelnikow