Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route pattern doesn't support trailing optional #2497

Closed
paulmelnikow opened this issue Dec 10, 2018 · 0 comments
Closed

Route pattern doesn't support trailing optional #2497

paulmelnikow opened this issue Dec 10, 2018 · 0 comments
Labels
blocker PRs and epics which block other work bug Bugs in badges and the frontend core Server, BaseService, GitHub auth, Shared helpers

Comments

@paulmelnikow
Copy link
Member

As mentioned in the rewriting services doc:

At present, the trailing parameter of a pattern can't be optional. If the last part of a route is optional, like a branch, you will need to use a format regex string (e.g. format: '([^/]+/[^/]+)').

Have got an issue open upstream in pillarjs/path-to-regexp#173, though it's not clear how that will be resolved and it's worth having a place to track this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker PRs and epics which block other work bug Bugs in badges and the frontend core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Development

No branches or pull requests

1 participant