-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support static preview with social style #2479
Comments
Given we've only got 6 social badges in the home page examples (out of some-hundred in total), I reckon static preview for social badges would be nice to have but its quite low priority. |
It's true it's not so important to render it statically, though it would be nice to drop support for |
paulmelnikow
added a commit
that referenced
this issue
Jan 25, 2019
paulmelnikow
added a commit
that referenced
this issue
Jan 29, 2019
The static previews don't support the social badges. Adding that lets us remove support for `exampleUrl`. Close #2479. This includes `style` and `namedLogo` in the service-definition export and updates the frontend to use it. To accomplish this, it passes `namedLogo` through `coalesceBadge`. After logo resolution is moved to `makeBadge` this duplication can be removed, as `logo` will no longer be needed in the result of `coalesceBadge`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The social badges have typically included
?style=social
. HoweverstaticPreview
returnsserviceData
which does not support thestyle
parameter. This makes it impossible to render a static preview for the social badges.e.g.
shields/services/github/github-followers.service.js
Lines 32 to 36 in f8b0472
This also came up in #2473 where I was adding an Endpoint badge, and thinking we should make it possible for a developer to make a badge which defaults to a particular style.
I'm not totally convinced we should do that. In some ways it violates a user's expectation, which is that Shields will always default to flat. Should we also let the developer specify
flat-square
orfor-the-badge
? At the same time, these are custom badges, and it's useful to be able to include especially logos by default. Maybe it's okay, for custom badges.The text was updated successfully, but these errors were encountered: