Skip to content

[NFC] Fix a couple of types in the comments #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[NFC] Fix a couple of types in the comments #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sycl/plugins/opencl/pi_opencl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,10 @@ pi_result OCL(piextDeviceSelectBinary)(pi_device device,

// TODO: this is a bare-bones implementation for choosing a device image
// that would be compatible with the targeted device. An AOT-compiled
// image is preferred over SPIRV for known devices (i.e. Intel devices)
// image is preferred over SPIR-V for known devices (i.e. Intel devices)
// The implementation makes no effort to differentiate between multiple images
// for the given device, and simply picks the first one compatible
// Real implementaion will use the same mechanism OpenCL ICD dispatcher
// Real implementation will use the same mechanism OpenCL ICD dispatcher
// uses. Something like:
// PI_VALIDATE_HANDLE_RETURN_HANDLE(ctx, PI_INVALID_CONTEXT);
// return context->dispatch->piextDeviceSelectIR(
Expand Down