feat(egh): remove post from course post #397

zacjones93 · 2025-01-27T19:19:19Z

This follows the same pattern used to remove posts as implemented for adding posts.

Another PR should be considered to consolidate this syncing logic into it's own lib file

vercel · 2025-01-27T19:19:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai-hero	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 28, 2025 5:10pm
course-builder-egghead	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 28, 2025 5:10pm
course-builder-poc	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 28, 2025 5:10pm
epic-react-builder	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 28, 2025 5:10pm
go-local-first	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 28, 2025 5:10pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
astro-party	⬜️ Ignored (Inspect)	Visit Preview		Jan 28, 2025 5:10pm

zacjones93 · 2025-01-27T19:22:25Z

apps/egghead/src/app/(content)/posts/_components/resource-resources-list.tsx

+				onDelete={async ({ itemId }: { itemId: string }) => {
+					const post = await getPost(itemId)
+
+					if (!post || !post.fields?.eggheadLessonId) {
+						throw new Error('eggheadLessonId is required')
+					}
+
+					await removePostFromCoursePost({
+						postId: itemId,
+						resourceOfId: resource.id,
+					})
+
+					await removeEggheadLessonFromPlaylist({
+						eggheadLessonId: post.fields?.eggheadLessonId,
+						eggheadPlaylistId: resource.fields?.eggheadPlaylistId,
+					})
+				}}


following pattern seen in EditResourcesForm where we define logic at the top level and pass function down to where it is called

this whole stack might move into a single function in post-query or similar instead of being buried in a component so it'd be a si ngle call here

zacjones93 · 2025-01-27T19:24:04Z

apps/egghead/src/app/(content)/posts/actions.ts

+	return await db
+		.delete(contentResourceResource)
+		.where(
+			and(
+				eq(contentResourceResource.resourceOfId, resourceOfId),
+				eq(contentResourceResource.resourceId, postId),
+			),
+		)


needs to run on the server so put function in actions folder. Reviewing it now, this should probably be in posts-query?

maybe, actions need to absolutely do auth checks though, regardless. review everything for that plz. As is a smart haxx0r could probably trigger this

zacjones93 · 2025-01-27T19:24:30Z

apps/egghead/src/components/lesson-list/pieces/tree/tree-item.tsx

-				{item.type === 'section' && item.children.length === 0 && (
+				{item.type === 'post' && (


we don't have sections in egghead right now so switched this block for post deletion

zacjones93 · 2025-01-27T19:24:56Z

apps/egghead/src/lib/posts-query.ts

+		const response = await fetch(
+			`${EGGHEAD_API_V1_BASE_URL}/playlists/${eggheadPlaylistId}/items/remove`,
+			{
+				method: 'PUT',
+				headers: {
+					'Content-Type': 'application/json',
+					Authorization: `Bearer ${eggheadToken}`,
+					'User-Agent': 'authjs',
+				},
+				body: JSON.stringify({
+					tracklistable: {
+						tracklistable_type: 'Lesson',
+						tracklistable_id: eggheadLessonId,
+					},
+				}),
+			},
+		).then(async (res) => {
+			if (!res.ok) {
+				console.log('Error removing lesson from playlist', res)
+				throw new EggheadApiError(res.statusText, res.status)
+			}
+			return await res.json()
+		})


the syncing work

this isn't critical, but unless it provides added benefit I'd like to move away from using the API and do the work directly against the DB, but there might be advantages to the API (related business processes that occur etc), but for basic crud...

@Creeland and I went this initial route because of the tracklist table/logic involved with playlists but we can look at refactoring these api calls to DB operations as a next step

ya it's definitely simpler/safer but more coupled to rails so tradeoff is a thing. It's fine, just something to consider. Wouldn't change for this PR for sure.

joelhooks

the authorization stuff needs to be addressed

joelhooks · 2025-01-27T20:11:46Z

apps/egghead/src/lib/posts-query.ts

+		const response = await fetch(
+			`${EGGHEAD_API_V1_BASE_URL}/playlists/${eggheadPlaylistId}/items/remove`,
+			{
+				method: 'PUT',
+				headers: {
+					'Content-Type': 'application/json',
+					Authorization: `Bearer ${eggheadToken}`,
+					'User-Agent': 'authjs',
+				},
+				body: JSON.stringify({
+					tracklistable: {
+						tracklistable_type: 'Lesson',
+						tracklistable_id: eggheadLessonId,
+					},
+				}),
+			},
+		).then(async (res) => {
+			if (!res.ok) {
+				console.log('Error removing lesson from playlist', res)
+				throw new EggheadApiError(res.statusText, res.status)
+			}
+			return await res.json()
+		})


this isn't critical, but unless it provides added benefit I'd like to move away from using the API and do the work directly against the DB, but there might be advantages to the API (related business processes that occur etc), but for basic crud...

joelhooks · 2025-01-27T20:14:42Z

apps/egghead/src/app/(content)/posts/actions.ts

+	return await db
+		.delete(contentResourceResource)
+		.where(
+			and(
+				eq(contentResourceResource.resourceOfId, resourceOfId),
+				eq(contentResourceResource.resourceId, postId),
+			),
+		)


maybe, actions need to absolutely do auth checks though, regardless. review everything for that plz. As is a smart haxx0r could probably trigger this

joelhooks · 2025-01-27T20:15:47Z

apps/egghead/src/app/(content)/posts/_components/resource-resources-list.tsx

+				onDelete={async ({ itemId }: { itemId: string }) => {
+					const post = await getPost(itemId)
+
+					if (!post || !post.fields?.eggheadLessonId) {
+						throw new Error('eggheadLessonId is required')
+					}
+
+					await removePostFromCoursePost({
+						postId: itemId,
+						resourceOfId: resource.id,
+					})
+
+					await removeEggheadLessonFromPlaylist({
+						eggheadLessonId: post.fields?.eggheadLessonId,
+						eggheadPlaylistId: resource.fields?.eggheadPlaylistId,
+					})
+				}}


this whole stack might move into a single function in post-query or similar instead of being buried in a component so it'd be a si ngle call here

zacjones93 · 2025-01-27T22:14:25Z

apps/egghead/src/app/(content)/posts/_components/resource-resources-list.tsx

+					try {
+						await removePostFromCoursePost({
+							postId: itemId,
+							resourceOfId: resource.id,
+						})
+					} catch (error) {
+						console.error('Error removing lesson from playlist', error)
+						toast({
+							title: 'Error removing lesson from playlist',
+							description: 'Please refresh the page and try again.',
+							variant: 'destructive',
+						})
+					}


https://www.loom.com/share/3dd17151bdd94a559db99770466c2293?sid=a6ecd7b2-df5f-404d-9bf4-e86e4d18c7f6

Added some error handling that lets user know something went wrong in a toast

feat(egh): remove post from course post

ff05089

zacjones93 requested review from joelhooks and Creeland January 27, 2025 19:19

vercel bot deployed to Preview – course-builder-egghead January 27, 2025 19:19 View deployment

zacjones93 commented Jan 27, 2025

View reviewed changes

joelhooks reviewed Jan 27, 2025

View reviewed changes

zacjones93 added 4 commits January 27, 2025 14:56

feat(egh): enhance post removal with egghead playlist sync

3033fe0

refactor(egh): optimistically delete item

551b6b4

feat(egh): auth post removal

54f935e

feat(egh): show toast when syncing breaks

a333c35

vercel bot deployed to Preview – epic-react-builder January 27, 2025 22:13 View deployment

vercel bot deployed to Preview – course-builder-poc January 27, 2025 22:13 View deployment

vercel bot deployed to Preview – go-local-first January 27, 2025 22:14 View deployment

vercel bot deployed to Preview – ai-hero January 27, 2025 22:14 View deployment

zacjones93 commented Jan 27, 2025

View reviewed changes

vercel bot deployed to Preview – course-builder-egghead January 27, 2025 22:16 View deployment

Merge branch 'main' into zac/remove-post-from-course

ffb2dfc

vercel bot deployed to Preview – epic-react-builder January 28, 2025 17:09 View deployment

vercel bot deployed to Preview – course-builder-poc January 28, 2025 17:09 View deployment

vercel bot deployed to Preview – course-builder-egghead January 28, 2025 17:09 View deployment

vercel bot deployed to Preview – go-local-first January 28, 2025 17:09 View deployment

vercel bot deployed to Preview – ai-hero January 28, 2025 17:10 View deployment

Creeland approved these changes Jan 28, 2025

View reviewed changes

kodiakhq bot merged commit 8669292 into main Jan 28, 2025
18 checks passed

kodiakhq bot deleted the zac/remove-post-from-course branch January 28, 2025 17:15

		{item.type === 'section' && item.children.length === 0 && (
		{item.type === 'post' && (

feat(egh): remove post from course post #397

feat(egh): remove post from course post #397

Uh oh!

Conversation

zacjones93 commented Jan 27, 2025

Uh oh!

vercel bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joelhooks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vercel bot commented Jan 27, 2025 •

edited

Loading