react-native: android crash handler upgrade #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konraddysput
changed the title
konraddysput
changed the base branch from
feature/react-native-example-update
to
main
konraddysput
changed the base branch from
main
to
feature/react-native-example-update
konraddysput
force-pushed
the
improvement/react-native-android-crash-handler-upgrade
branch
from
3f6a589 to
a23e335
Compare
konraddysput
changed the base branch from
feature/react-native-example-update
to
main
perf2711
reviewed
Oct 16, 2024
packages/react-native/android/src/main/java/backtrace/library/BacktraceReactNative.java
Show resolved
Hide resolved
packages/react-native/android/src/main/java/backtrace/library/common/AbiHelper.java
Show resolved
Hide resolved
.../android/src/main/java/backtrace/library/models/nativeHandler/CrashHandlerConfiguration.java
Show resolved
Hide resolved
.../android/src/main/java/backtrace/library/models/nativeHandler/CrashHandlerConfiguration.java
Show resolved
Hide resolved
.../android/src/main/java/backtrace/library/models/nativeHandler/CrashHandlerConfiguration.java
Show resolved
Hide resolved
perf2711
requested changes
Oct 16, 2024
perf2711
approved these changes
Oct 21, 2024
konraddysput
deleted the
improvement/react-native-android-crash-handler-upgrade
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This pull request upgrades the native crash reporting solution to the latest version from backtrace-android. All changes introduced in the: https://github.com/backtrace-labs/backtrace-android/pull/128/files are now also available here.
Why do we need those?
The new version of the AGP prevents executables from being added to NDK libraries. Due to this, we cannot use the crash handler the same way. With these changes, instead of having an executable, that sends a crash code, we have a java class responsible for a minidump generation.
ref: BT-5028