Crashpad - replace crashpad_handler executable with JavaCrashHandler #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backtrace-library/src/androidTest/java/backtraceio/library/AndroidManifest.xml
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/BacktraceCrashHandler.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/BacktraceCrashHandler.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/BacktraceCrashHandler.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/BacktraceCrashHandler.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/BacktraceDatabase.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/BacktraceDatabase.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/BacktraceCrashHandler.java
Outdated
Show resolved
Hide resolved
konraddysput
commented
May 28, 2024
backtrace-library/src/main/java/backtraceio/library/services/BacktraceCrashHandler.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/BacktraceCrashHandler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This diff replaces the old strategy of using crashpad_handler executable with the new JavaCrashHandler setup. Due to updates to AGP, by default native libraries are not extracted. Because of this, our customers need to use useLegacyPackaging flag to use our NDK support.
To avoid using legacy packaging flags, we wanted to change the way how Crashpad works. Instead of using crashpad_handler executable, this pull request exposes the
BacktraceCrashHandlerclass that will be spawned by app_process when the crash occurs. The class is a wrapper around Crashpad dumping API, that allows us to generate a minidump and send it the same way like crashpad handler would do.To avoid too big scope of the change, in future pull requests, we want to: