feat(acr): adding support for internationalization (i18n) #6246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
its-mitesh-kumar
requested review from
a team,
christoph-jerolimov,
ciiay,
debsmita1,
divyanshiGupta and
logonoff
as code owners
Contributor
Changed Packages
|
its-mitesh-kumar
changed the title
logonoff
reviewed
Nov 28, 2025
| import { ManifestDigestChip } from './ManifestDigestChip'; | ||
|
|
||
| export const columns: TableColumn<TagRow>[] = [ | ||
| export const getColumns = ( |
Member
There was a problem hiding this comment.
maybe this is better suited as a useMemo now?
logonoff
reviewed
Nov 28, 2025
| const title = `Azure Container Registry Repository: ${image}`; | ||
| const { t } = useTranslation(); | ||
| const title = t( | ||
| 'page.title' as keyof typeof acrTranslationRef.T, |
Member
There was a problem hiding this comment.
Bookmarks plugin has an example of useTranslation that removes the need for these type assertions if you want that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding internationalization (i18n) support with German, French, Italian, Spanish and Japanese translations.
##Fixed
Fixing https://issues.redhat.com/browse/RHIDP-9721
UI after changes
Screen.Recording.2025-11-26.at.11.mp4
Signed-off-byline in the message. (more info)