-
Notifications
You must be signed in to change notification settings - Fork 510
feat(azure-devops): Add option to fail action if pipeline is unsuccessful #5971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(azure-devops): Add option to fail action if pipeline is unsuccessful #5971
Conversation
Signed-off-by: Oskar Jiang <oskarjiang94@gmail.com>
Signed-off-by: Oskar Jiang <oskarjiang94@gmail.com>
Changed Packages
|
...azure-devops/plugins/scaffolder-backend-module-azure-devops/src/actions/devopsRunPipeline.ts
Show resolved
Hide resolved
Signed-off-by: Oskar Jiang <oskarjiang94@gmail.com>
Signed-off-by: Oskar Jiang <oskarjiang94@gmail.com>
|
@awanlin please have a look when you have time |
I'll be giving it a look this Friday now that I'm back from BackstageCon/KubeCon 👍 |
awanlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @oskarjiang, code looks great just got a few places that need to be updated as well:
- Please add a new example using this here: https://github.com/backstage/community-plugins/blob/172d01b08275d602e9a1520c1a141ef7a704fb8e/workspaces/azure-devops/plugins/scaffolder-backend-module-azure-devops/src/actions/devopsCreatePipeline.examples.ts
- Also add a new example using this here too: https://github.com/backstage/community-plugins/blob/main/workspaces/azure-devops/plugins/scaffolder-backend-module-azure-devops/README.md#usage
Signed-off-by: Oskar Jiang <oskarjiang94@gmail.com>
Added 🙂 |
awanlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @oskarjiang, let's get this out there so people can use it! 🚀
Hey, I just made a Pull Request!
✔️ Checklist
Signed-off-byline in the message. (more info)