hotfix(bazaar) add virtualization to UserSelector dropdown #1747
+128
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Rothenberg <rothenbergt@gmail.com>
rothenbergt
requested review from
backstage-service and
a team
as code owners
Changed Packages
|
awanlin
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Thanks for the improvements here @rothenbergt. I'll admit it's too bad that VirtualizedListbox wasn't exported in say something like Core Components in the main Backstage repo. Might be worth looking into if you have time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
The
UserSelectordropdown introduced in #1535 was experiencing performance issues with large user lists (1000+ entries) due to rendering all options at once.Added a VirtualizedListbox component matching the pattern used by EntityPicker. This significantly improves dropdown performance by rendering only ~11 entries at a time instead of all entries.
Refactored a couple other things to better match
EntityPicker's patterns.✔️ Checklist
Signed-off-byline in the message. (more info)