Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed API Extractor Resolution #1709

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Removed API Extractor Resolution #1709

wants to merge 4 commits into from
+11 −8

Conversation

awanlin
Copy link
Contributor

@awanlin awanlin commented Oct 19, 2024

Hey, I just made a Pull Request!

Removed @microsoft/api-extractor from resolutions in the package.json file as it is no longer needed since the Backstage 1.32.0 release

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@awanlin awanlin requested a review from a team as a code owner October 19, 2024 22:27
@awanlin awanlin requested a review from vinzscam October 19, 2024 22:27
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Oct 19, 2024 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/cli workspaces/repo-tools/packages/cli none v0.0.3
@backstage-community/plugin-sentry workspaces/sentry/plugins/sentry patch v1.0.1
@backstage-community/plugin-sonarqube workspaces/sonarqube/plugins/sonarqube patch v0.8.4

@awanlin
Removed API Extractor Resolution
18358ad 
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin
Fixed typo
4d911f7 
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin awanlin force-pushed the topic/remove-repo-tools-api-extractor-resolution branch from 98a9613 to 4d911f7 Compare October 19, 2024 23:23
@awanlin
Removed a few others that were missed
7a5f303 
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin awanlin requested a review from a team as a code owner October 19, 2024 23:28
04kash
04kash approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@04kash 04kash left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Do we need a changeset for @backstage-community/cli? Since it's private I'd assume not.

@awanlin
Removed changeset based on feedback
8dea151 
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin awanlin requested a review from vinzscam October 23, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@04kash 04kash 04kash approved these changes

@vinzscam vinzscam Awaiting requested review from vinzscam

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awanlin @vinzscam @04kash