Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure:pipeline:run scaffolder action #1358

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

Phiph
Copy link

@Phiph Phiph commented Sep 27, 2024

Hey, I just made a Pull Request!

I've introduced a azure:pipeline:run scaffolder action.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • [] Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@Phiph Phiph requested review from awanlin and a team as code owners September 27, 2024 22:04
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Sep 27, 2024

Unnecessary Changesets

The following package(s) are private and do not need a changeset:

  • @backstage-community/plugin-scaffolder-backend-module-azure-devops

Changed Packages

Package Name Package Path Changeset Bump Current Version
backend workspaces/azure-devops/packages/backend none v0.0.11
@backstage-community/plugin-scaffolder-backend-module-azure-devops workspaces/azure-devops/plugins/scaffolder-backend-module-azure-devops minor v0.1.0

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@Phiph Phiph force-pushed the Azure-scaffolder-actions branch 3 times, most recently from 92fdf1d to d859a2e Compare September 27, 2024 22:23
@awanlin
Copy link
Contributor

awanlin commented Sep 28, 2024

Hi @Phiph, I'd like to just hit pause on this and get some quick feedback in this issue I logged: #1393

@Phiph
Copy link
Author

Phiph commented Sep 29, 2024

Thanks @awanlin.

Hopefully from the git commits & the difference in the implementation that it's all fresh code.

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Oct 14, 2024
@awanlin awanlin removed the stale label Oct 21, 2024
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Phiph, gave this a look over, great work, just some naming and organization comments. Should all be quick to address 👍

workspaces/azure-devops/.changeset/lemon-geese-pump.md Outdated Show resolved Hide resolved
workspaces/azure-devops/app-config.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I "think" this should be one folder up and we would remove the example folder, just following what I see here: https://github.com/backstage/backstage/tree/master/plugins/scaffolder-backend-module-azure/src/actions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also make sure to add the example file like this one: https://github.com/backstage/backstage/blob/master/plugins/scaffolder-backend-module-azure/src/actions/azure.examples.ts ? This is what powers the inputs, outputs, and examples shown here: https://demo.backstage.io/create/actions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I've looked at the other modules in the repo, and they all follow the pattern of integrationActionName. I've just committed a change that's renamed the files to devopsRunPipeline what do you think?

@awanlin
Copy link
Contributor

awanlin commented Oct 21, 2024

Oh, if you could rebase as well that would be good. I did the 1.32.2 version bump for the plugin workspace which has created some conflicts for you. Sorry about that.

@Phiph
Copy link
Author

Phiph commented Oct 22, 2024

Thanks Andre I'll sort out these changes shortly :)

Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com>
@Phiph Phiph force-pushed the Azure-scaffolder-actions branch 4 times, most recently from 3b254cc to 5438696 Compare October 22, 2024 22:28
Phiph and others added 9 commits October 23, 2024 00:19
Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com>

Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <phill.morton@theaccessgroup.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <phill.morton@theaccessgroup.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <phill.morton@theaccessgroup.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <phill.morton@theaccessgroup.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <phill.morton@theaccessgroup.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants