-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add azure:pipeline:run scaffolder action #1358
base: main
Are you sure you want to change the base?
Conversation
Unnecessary ChangesetsThe following package(s) are private and do not need a changeset:
Changed Packages
|
Thanks for the contribution! |
92fdf1d
to
d859a2e
Compare
Thanks @awanlin. Hopefully from the git commits & the difference in the implementation that it's all fresh code. |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Phiph, gave this a look over, great work, just some naming and organization comments. Should all be quick to address 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I "think" this should be one folder up and we would remove the example folder, just following what I see here: https://github.com/backstage/backstage/tree/master/plugins/scaffolder-backend-module-azure/src/actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also make sure to add the example file like this one: https://github.com/backstage/backstage/blob/master/plugins/scaffolder-backend-module-azure/src/actions/azure.examples.ts ? This is what powers the inputs, outputs, and examples shown here: https://demo.backstage.io/create/actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I've looked at the other modules in the repo, and they all follow the pattern of integrationActionName
. I've just committed a change that's renamed the files to devopsRunPipeline
what do you think?
...plugins/scaffolder-backend-module-azure-pipeline-actions/src/actions/example/run-pipeline.ts
Outdated
Show resolved
Hide resolved
...plugins/scaffolder-backend-module-azure-pipeline-actions/src/actions/example/run-pipeline.ts
Outdated
Show resolved
Hide resolved
Oh, if you could rebase as well that would be good. I did the |
Thanks Andre I'll sort out these changes shortly :) |
Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com>
3b254cc
to
5438696
Compare
Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com> Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com> Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <phill.morton@theaccessgroup.com> Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <phill.morton@theaccessgroup.com> Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <phill.morton@theaccessgroup.com> Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <phill.morton@theaccessgroup.com> Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <phill.morton@theaccessgroup.com> Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com> Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com> Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com> Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phillip Morton <Phiph@users.noreply.github.com> Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
Signed-off-by: Phill Morton <Phiph@users.noreply.github.com>
130aead
to
f476f85
Compare
Hey, I just made a Pull Request!
I've introduced a
azure:pipeline:run
scaffolder action.✔️ Checklist
Signed-off-by
line in the message. (more info)