Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused UserFlags type #7935

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Remove the unused UserFlags type #7935

merged 1 commit into from
Nov 11, 2021

Conversation

freben
Copy link
Member

@freben freben commented Nov 10, 2021

Technically a breaking change - but it's completely unused and empty, so I chose to just tear it out instead of properly deprecating etc.

Part of #7700

@freben freben requested a review from a team as a code owner November 10, 2021 13:30
@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2021

🦋 Changeset detected

Latest commit: 7e18ed7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@backstage/core-plugin-api Minor
example-app Patch
@backstage/core-app-api Patch
@backstage/core-components Patch
@backstage/dev-utils Patch
@backstage/integration-react Patch
@backstage/test-utils Patch
@backstage/plugin-allure Patch
@backstage/plugin-analytics-module-ga Patch
@backstage/plugin-api-docs Patch
@backstage/plugin-azure-devops Patch
@backstage/plugin-badges Patch
@backstage/plugin-bazaar Patch
@backstage/plugin-bitrise Patch
@backstage/plugin-catalog-graph Patch
@backstage/plugin-catalog-import Patch
@backstage/plugin-catalog-react Patch
@backstage/plugin-catalog Patch
@backstage/plugin-circleci Patch
@backstage/plugin-cloudbuild Patch
@backstage/plugin-code-coverage Patch
@backstage/plugin-config-schema Patch
@backstage/plugin-cost-insights Patch
@backstage/plugin-explore-react Patch
@backstage/plugin-explore Patch
@backstage/plugin-firehydrant Patch
@backstage/plugin-fossa Patch
@backstage/plugin-gcp-projects Patch
@backstage/plugin-git-release-manager Patch
@backstage/plugin-github-actions Patch
@backstage/plugin-github-deployments Patch
@backstage/plugin-gitops-profiles Patch
@backstage/plugin-graphiql Patch
@backstage/plugin-home Patch
@backstage/plugin-ilert Patch
@backstage/plugin-jenkins Patch
@backstage/plugin-kafka Patch
@backstage/plugin-kubernetes Patch
@backstage/plugin-lighthouse Patch
@backstage/plugin-newrelic Patch
@backstage/plugin-org Patch
@backstage/plugin-pagerduty Patch
@backstage/plugin-rollbar Patch
@backstage/plugin-scaffolder Patch
@backstage/plugin-search Patch
@backstage/plugin-sentry Patch
@backstage/plugin-shortcuts Patch
@backstage/plugin-sonarqube Patch
@backstage/plugin-splunk-on-call Patch
@backstage/plugin-tech-radar Patch
@backstage/plugin-techdocs Patch
@backstage/plugin-todo Patch
@backstage/plugin-user-settings Patch
@backstage/plugin-xcmetrics Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense tbh, not a very useful type either 😅

@Rugvip
Copy link
Member

Rugvip commented Nov 10, 2021

How do you feel about making it minor and merging it after tomorrow's release though? Feeling it's fine to break this particular API without warning, but would be nicer to do in with a minor bump tbh

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
@freben
Copy link
Member Author

freben commented Nov 10, 2021

sure! done

@freben freben merged commit 4adcd21 into master Nov 11, 2021
@freben freben deleted the freben/userflags branch November 11, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants