Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redmine 2.2.1] DEPRECATION WARNING: Passing a template handler in the template name is deprecated #793

Open
cforce opened this issue Jan 16, 2013 · 11 comments

Comments

@cforce
Copy link
Contributor

cforce commented Jan 16, 2013

platform: # supported: 2.2.4, 2.3.2
backlogs: # supported: 1.0.5
ruby: # supported: 1.9.3, 2.0.0

DEPRECATION WARNING: Passing a template handler in the template name is deprecated. You can simply remove the handler name or pass render :handlers => [:erb] instead. (called from realtime at /home/sidfunktion/.rvm/rubies/ruby-1.9.3-p327/lib/ruby/1.9.1/benchmark.rb:295)
Rendered plugins/redmine_backlogs/app/views/rb_server_variables/show.js.erb (3.4ms)

@patrickatamaniuk
Copy link
Contributor

@Vanuan do we need to support rails 2 any longer? Otherwise updating the render calls i can do.

@Vanuan
Copy link
Contributor

Vanuan commented Jan 19, 2013

Personally, I don't object. But probably there are many users who stuck with rails2. Possible solution would be to do the same redmine folks did - drop rails 2 and update the major version. Probably, make a branch for security updates.

@Vanuan
Copy link
Contributor

Vanuan commented Jan 19, 2013

Rails 4 is coming, so dropping Rails 2 would be an understandable move.

@Vanuan
Copy link
Contributor

Vanuan commented Jan 19, 2013

It seems like Rails 2 was already dropped, since Redmine 1.4.x doesn't run on travis.

patrickatamaniuk added a commit to patrickatamaniuk/redmine_backlogs that referenced this issue Mar 7, 2013
@patrickatamaniuk
Copy link
Contributor

@Vanuan opened a rails3 branch on my fork, going berserk about rails3 query interface and avoiding rails4 deprecations. If you like have a look and stop me from doing stupid things, please :-)

@Vanuan
Copy link
Contributor

Vanuan commented Mar 9, 2013

@patrickatamaniuk Great job! One major advantage of abandoning rails2 is that all gems can be updated to the latest versions.

@Vanuan
Copy link
Contributor

Vanuan commented Mar 9, 2013

Though, I'm a little bit concerned that the code is getting more complex: https://codeclimate.com/github/backlogs/redmine_backlogs

@patrickatamaniuk
Copy link
Contributor

code is getting more complex

i've seen that :( but actually when i look at e.g. rb_story, i am at loss... Broke up the find_options method for code climate (and my eyes), but the reward at code climate is still F. I'm also aware of some duplications, some are probably not avoidable. Hmm.

@Jellyfrog
Copy link

Rails 4 been out for like a year.
Redmine lists Rails 3.2 as required, time to commit this into master?

@Vanuan
Copy link
Contributor

Vanuan commented Jun 9, 2014

Seems like the project has lost maintainer. Would you like to contribute?

@Jellyfrog
Copy link

Sorry i'm not a ruby dev, but you could take this commit:
patrickatamaniuk@fb8e91e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants