-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[redmine 2.2.1] DEPRECATION WARNING: Passing a template handler in the template name is deprecated #793
Comments
@Vanuan do we need to support rails 2 any longer? Otherwise updating the render calls i can do. |
Personally, I don't object. But probably there are many users who stuck with rails2. Possible solution would be to do the same redmine folks did - drop rails 2 and update the major version. Probably, make a branch for security updates. |
Rails 4 is coming, so dropping Rails 2 would be an understandable move. |
It seems like Rails 2 was already dropped, since Redmine 1.4.x doesn't run on travis. |
@Vanuan opened a rails3 branch on my fork, going berserk about rails3 query interface and avoiding rails4 deprecations. If you like have a look and stop me from doing stupid things, please :-) |
@patrickatamaniuk Great job! One major advantage of abandoning rails2 is that all gems can be updated to the latest versions. |
Though, I'm a little bit concerned that the code is getting more complex: https://codeclimate.com/github/backlogs/redmine_backlogs |
i've seen that :( but actually when i look at e.g. rb_story, i am at loss... Broke up the find_options method for code climate (and my eyes), but the reward at code climate is still F. I'm also aware of some duplications, some are probably not avoidable. Hmm. |
Rails 4 been out for like a year. |
Seems like the project has lost maintainer. Would you like to contribute? |
Sorry i'm not a ruby dev, but you could take this commit: |
platform: # supported: 2.2.4, 2.3.2
backlogs: # supported: 1.0.5
ruby: # supported: 1.9.3, 2.0.0
DEPRECATION WARNING: Passing a template handler in the template name is deprecated. You can simply remove the handler name or pass render :handlers => [:erb] instead. (called from realtime at /home/sidfunktion/.rvm/rubies/ruby-1.9.3-p327/lib/ruby/1.9.1/benchmark.rb:295)
Rendered plugins/redmine_backlogs/app/views/rb_server_variables/show.js.erb (3.4ms)
The text was updated successfully, but these errors were encountered: