Skip to content

Issue #6815: Consider access to path before using simplified display #4984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

indigoxela
Copy link
Member

@backdrop-ci
Copy link
Collaborator

Related to: backdrop/backdrop-issues#6815

@indigoxela
Copy link
Member Author

Hm... a second try, as this (sort of unrelated test) passes locally...

@indigoxela indigoxela closed this Jan 9, 2025
@indigoxela indigoxela reopened this Jan 9, 2025
@dragonbot
Copy link
Collaborator

Tugboat has finished building a preview for this pull request!

Website: https://pr4984-fstkuaga15zha3aifs1rseht86sxejel.tugboatqa.com/
Username: admin
Password: 271e215e0a5e

This preview will automatically expire on the 10th of March, 2025.

@indigoxela
Copy link
Member Author

indigoxela commented Jan 14, 2025

Triggering sandbox creation. Edit: didn't work. 🤷 If you have to, test locally. 😉

@indigoxela indigoxela closed this Jan 14, 2025
@indigoxela indigoxela reopened this Jan 14, 2025
@laryn laryn merged commit ee52da3 into backdrop:1.x Jan 15, 2025
24 of 25 checks passed
@laryn
Copy link
Contributor

laryn commented Jan 15, 2025

Thank you @indigoxela! Merged into 1.x for 1.30.0.

Dawnthorn added a commit to giant-rabbit/backdrop that referenced this pull request May 6, 2025
The link module calls url() twice on the the same URL. If the site has
local enabled and is setup to detect the language with URL prefixes,
then it will add the prefix a second time to a path that already has the
language prefix. For example, it will rewrite fr/node/16 to
fr/fr/node/16. Having the locale module not add the prefix again if it's
already there, fixes this.
Dawnthorn added a commit to giant-rabbit/backdrop that referenced this pull request May 6, 2025
The link module calls url() twice on the the same URL. If the site has
local enabled and is setup to detect the language with URL prefixes,
then it will add the prefix a second time to a path that already has the
language prefix. For example, it will rewrite fr/node/16 to
fr/fr/node/16. Having the locale module not add the prefix again if it's
already there, fixes this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-up: Consider if the page is accessible by current user before using simplified display
6 participants